Skip to content

Commit 6792966

Browse files
ericscipleericsciple
committed
Bump version to 2.333.1
1 parent 8d231aa commit 6792966

File tree

15 files changed

+74
-113
lines changed

15 files changed

+74
-113
lines changed

‎releaseNote.md‎

Lines changed: 3 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,7 @@
11
## What's Changed
2-
* Log inner exception message. by @TingluoHuang in https://github.com/actions/runner/pull/4265
3-
* Fix composite post-step marker display names by @ericsciple in https://github.com/actions/runner/pull/4267
4-
* Bump actions/download-artifact from 7 to 8 by @dependabot[bot] in https://github.com/actions/runner/pull/4269
5-
* chore: update Node versions by @github-actions[bot] in https://github.com/actions/runner/pull/4272
6-
* Avoid throw in SelfUpdaters. by @TingluoHuang in https://github.com/actions/runner/pull/4274
7-
* Fix parser comparison mismatches by @ericsciple in https://github.com/actions/runner/pull/4273
8-
* Devcontainer: bump base image Ubuntu version by @MaxHorstmann in https://github.com/actions/runner/pull/4277
9-
* Support `entrypoint` and `command` for service containers by @ericsciple in https://github.com/actions/runner/pull/4276
10-
* Bump actions/upload-artifact from 6 to 7 by @dependabot[bot] in https://github.com/actions/runner/pull/4270
11-
* Bump docker/login-action from 3 to 4 by @dependabot[bot] in https://github.com/actions/runner/pull/4278
12-
* Fix positional arg bug in ExpressionParser.CreateTree by @ericsciple in https://github.com/actions/runner/pull/4279
13-
* Bump docker/build-push-action from 6 to 7 by @dependabot[bot] in https://github.com/actions/runner/pull/4283
14-
* Bump docker/setup-buildx-action from 3 to 4 by @dependabot[bot] in https://github.com/actions/runner/pull/4282
15-
* Bump actions/attest-build-provenance from 3 to 4 by @dependabot[bot] in https://github.com/actions/runner/pull/4266
16-
* Bump @stylistic/eslint-plugin from 5.9.0 to 5.10.0 in /src/Misc/expressionFunc/hashFiles by @dependabot[bot] in https://github.com/actions/runner/pull/4281
17-
* Update Docker to v29.3.0 and Buildx to v0.32.1 by @github-actions[bot] in https://github.com/actions/runner/pull/4286
18-
* chore: update Node versions by @github-actions[bot] in https://github.com/actions/runner/pull/4287
19-
* Fix cancellation token race during parser comparison by @ericsciple in https://github.com/actions/runner/pull/4280
20-
* Bump @typescript-eslint/eslint-plugin from 8.47.0 to 8.54.0 in /src/Misc/expressionFunc/hashFiles by @dependabot[bot] in https://github.com/actions/runner/pull/4230
21-
* Exit with specified exit code when runner is outdated by @nikola-jokic in https://github.com/actions/runner/pull/4285
22-
* Report infra_error for action download failures. by @TingluoHuang in https://github.com/actions/runner/pull/4294
23-
* Update dotnet sdk to latest version @8.0.419 by @github-actions[bot] in https://github.com/actions/runner/pull/4301
24-
* Node 24 enforcement + Linux ARM32 deprecation support by @salmanmkc in https://github.com/actions/runner/pull/4303
25-
* Bump @typescript-eslint/eslint-plugin from 8.54.0 to 8.57.1 in /src/Misc/expressionFunc/hashFiles by @dependabot[bot] in https://github.com/actions/runner/pull/4304
26-
27-
## New Contributors
28-
* @MaxHorstmann made their first contribution in https://github.com/actions/runner/pull/4277
29-
30-
**Full Changelog**: https://github.com/actions/runner/compare/v2.332.0...v2.333.0
2+
* Remove AllowCaseFunction feature flag by @ericsciple in https://github.com/actions/runner/pull/4316
3+
4+
**Full Changelog**: https://github.com/actions/runner/compare/v2.333.0...v2.333.1
315

326
_Note: Actions Runner follows a progressive release policy, so the latest release might not be available to your enterprise, organization, or repository yet.
337
To confirm which version of the Actions Runner you should expect, please view the download instructions for your enterprise, organization, or repository.

‎releaseVersion‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2.333.0
1+
2.333.1

‎src/Runner.Worker/ActionManifestManager.cs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,6 @@ private TemplateContext CreateTemplateContext(
316316
Schema = _actionManifestSchema,
317317
// TODO: Switch to real tracewriter for cutover
318318
TraceWriter = new GitHub.Actions.WorkflowParser.ObjectTemplating.EmptyTraceWriter(),
319-
AllowCaseFunction = false,
320319
};
321320

322321
// Expression values from execution context

‎src/Runner.Worker/ActionManifestManagerLegacy.cs‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using System;
1+
using System;
22
using System.Collections.Generic;
33
using System.IO;
44
using System.Threading;
@@ -315,7 +315,6 @@ private TemplateContext CreateTemplateContext(
315315
maxBytes: 10 * 1024 * 1024),
316316
Schema = _actionManifestSchema,
317317
TraceWriter = executionContext.ToTemplateTraceWriter(),
318-
AllowCaseFunction = false,
319318
};
320319

321320
// Expression values from execution context

‎src/Sdk/DTExpressions2/Expressions2/ExpressionParser.cs‎

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,9 @@ public IExpressionNode CreateTree(
1717
String expression,
1818
ITraceWriter trace,
1919
IEnumerable<INamedValueInfo> namedValues,
20-
IEnumerable<IFunctionInfo> functions,
21-
Boolean allowCaseFunction = true)
20+
IEnumerable<IFunctionInfo> functions)
2221
{
23-
var context = new ParseContext(expression, trace, namedValues, functions, allowCaseFunction: allowCaseFunction);
22+
var context = new ParseContext(expression, trace, namedValues, functions);
2423
context.Trace.Info($"Parsing expression: <{expression}>");
2524
return CreateTree(context);
2625
}
@@ -416,20 +415,13 @@ private static Boolean TryGetFunctionInfo(
416415
String name,
417416
out IFunctionInfo functionInfo)
418417
{
419-
if (String.Equals(name, "case", StringComparison.OrdinalIgnoreCase) && !context.AllowCaseFunction)
420-
{
421-
functionInfo = null;
422-
return false;
423-
}
424-
425418
return ExpressionConstants.WellKnownFunctions.TryGetValue(name, out functionInfo) ||
426419
context.ExtensionFunctions.TryGetValue(name, out functionInfo);
427420
}
428421

429422
private sealed class ParseContext
430423
{
431424
public Boolean AllowUnknownKeywords;
432-
public Boolean AllowCaseFunction;
433425
public readonly String Expression;
434426
public readonly Dictionary<String, IFunctionInfo> ExtensionFunctions = new Dictionary<String, IFunctionInfo>(StringComparer.OrdinalIgnoreCase);
435427
public readonly Dictionary<String, INamedValueInfo> ExtensionNamedValues = new Dictionary<String, INamedValueInfo>(StringComparer.OrdinalIgnoreCase);
@@ -445,8 +437,7 @@ public ParseContext(
445437
ITraceWriter trace,
446438
IEnumerable<INamedValueInfo> namedValues,
447439
IEnumerable<IFunctionInfo> functions,
448-
Boolean allowUnknownKeywords = false,
449-
Boolean allowCaseFunction = true)
440+
Boolean allowUnknownKeywords = false)
450441
{
451442
Expression = expression ?? String.Empty;
452443
if (Expression.Length > ExpressionConstants.MaxLength)
@@ -467,7 +458,6 @@ public ParseContext(
467458

468459
LexicalAnalyzer = new LexicalAnalyzer(Expression);
469460
AllowUnknownKeywords = allowUnknownKeywords;
470-
AllowCaseFunction = allowCaseFunction;
471461
}
472462

473463
private class NoOperationTraceWriter : ITraceWriter

‎src/Sdk/DTObjectTemplating/ObjectTemplating/TemplateContext.cs‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -86,12 +86,6 @@ internal IDictionary<String, Object> State
8686

8787
internal ITraceWriter TraceWriter { get; set; }
8888

89-
/// <summary>
90-
/// Gets or sets a value indicating whether the case expression function is allowed.
91-
/// Defaults to true. Set to false to disable the case function.
92-
/// </summary>
93-
internal Boolean AllowCaseFunction { get; set; } = true;
94-
9589
private IDictionary<String, Int32> FileIds
9690
{
9791
get

‎src/Sdk/DTObjectTemplating/ObjectTemplating/Tokens/TemplateToken.cs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ protected StringToken EvaluateStringToken(
5757
var originalBytes = context.Memory.CurrentBytes;
5858
try
5959
{
60-
var tree = new ExpressionParser().CreateTree(expression, null, context.GetExpressionNamedValues(), context.ExpressionFunctions, allowCaseFunction: context.AllowCaseFunction);
60+
var tree = new ExpressionParser().CreateTree(expression, null, context.GetExpressionNamedValues(), context.ExpressionFunctions);
6161
var options = new EvaluationOptions
6262
{
6363
MaxMemory = context.Memory.MaxBytes,
@@ -94,7 +94,7 @@ protected SequenceToken EvaluateSequenceToken(
9494
var originalBytes = context.Memory.CurrentBytes;
9595
try
9696
{
97-
var tree = new ExpressionParser().CreateTree(expression, null, context.GetExpressionNamedValues(), context.ExpressionFunctions, allowCaseFunction: context.AllowCaseFunction);
97+
var tree = new ExpressionParser().CreateTree(expression, null, context.GetExpressionNamedValues(), context.ExpressionFunctions);
9898
var options = new EvaluationOptions
9999
{
100100
MaxMemory = context.Memory.MaxBytes,
@@ -123,7 +123,7 @@ protected MappingToken EvaluateMappingToken(
123123
var originalBytes = context.Memory.CurrentBytes;
124124
try
125125
{
126-
var tree = new ExpressionParser().CreateTree(expression, null, context.GetExpressionNamedValues(), context.ExpressionFunctions, allowCaseFunction: context.AllowCaseFunction);
126+
var tree = new ExpressionParser().CreateTree(expression, null, context.GetExpressionNamedValues(), context.ExpressionFunctions);
127127
var options = new EvaluationOptions
128128
{
129129
MaxMemory = context.Memory.MaxBytes,
@@ -152,7 +152,7 @@ protected TemplateToken EvaluateTemplateToken(
152152
var originalBytes = context.Memory.CurrentBytes;
153153
try
154154
{
155-
var tree = new ExpressionParser().CreateTree(expression, null, context.GetExpressionNamedValues(), context.ExpressionFunctions, allowCaseFunction: context.AllowCaseFunction);
155+
var tree = new ExpressionParser().CreateTree(expression, null, context.GetExpressionNamedValues(), context.ExpressionFunctions);
156156
var options = new EvaluationOptions
157157
{
158158
MaxMemory = context.Memory.MaxBytes,

‎src/Sdk/DTPipelines/Pipelines/ObjectTemplating/PipelineTemplateConverter.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -681,7 +681,7 @@ private static String ConvertToIfCondition(
681681
var node = default(ExpressionNode);
682682
try
683683
{
684-
node = expressionParser.CreateTree(condition, null, namedValues, functions, allowCaseFunction: context.AllowCaseFunction) as ExpressionNode;
684+
node = expressionParser.CreateTree(condition, null, namedValues, functions) as ExpressionNode;
685685
}
686686
catch (Exception ex)
687687
{

‎src/Sdk/Expressions/ExpressionParser.cs‎

Lines changed: 5 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#nullable disable // Consider removing in the future to minimize likelihood of NullReferenceException; refer https://learn.microsoft.com/en-us/dotnet/csharp/nullable-references
1+
#nullable disable // Consider removing in the future to minimize likelihood of NullReferenceException; refer https://learn.microsoft.com/en-us/dotnet/csharp/nullable-references
22

33
using System;
44
using System.Collections.Generic;
@@ -17,10 +17,9 @@ public IExpressionNode CreateTree(
1717
String expression,
1818
ITraceWriter trace,
1919
IEnumerable<INamedValueInfo> namedValues,
20-
IEnumerable<IFunctionInfo> functions,
21-
Boolean allowCaseFunction = true)
20+
IEnumerable<IFunctionInfo> functions)
2221
{
23-
var context = new ParseContext(expression, trace, namedValues, functions, allowCaseFunction: allowCaseFunction);
22+
var context = new ParseContext(expression, trace, namedValues, functions);
2423
context.Trace.Info($"Parsing expression: <{expression}>");
2524
return CreateTree(context);
2625
}
@@ -322,7 +321,7 @@ private static void FlushTopEndParameters(ParseContext context)
322321
context.Operators.Pop();
323322
}
324323
var functionOperands = PopOperands(context, parameterCount);
325-
324+
326325
// Node already exists on the operand stack
327326
function = (Function)context.Operands.Peek();
328327

@@ -416,20 +415,13 @@ private static Boolean TryGetFunctionInfo(
416415
String name,
417416
out IFunctionInfo functionInfo)
418417
{
419-
if (String.Equals(name, "case", StringComparison.OrdinalIgnoreCase) && !context.AllowCaseFunction)
420-
{
421-
functionInfo = null;
422-
return false;
423-
}
424-
425418
return ExpressionConstants.WellKnownFunctions.TryGetValue(name, out functionInfo) ||
426419
context.ExtensionFunctions.TryGetValue(name, out functionInfo);
427420
}
428421

429422
private sealed class ParseContext
430423
{
431424
public Boolean AllowUnknownKeywords;
432-
public Boolean AllowCaseFunction;
433425
public readonly String Expression;
434426
public readonly Dictionary<String, IFunctionInfo> ExtensionFunctions = new Dictionary<String, IFunctionInfo>(StringComparer.OrdinalIgnoreCase);
435427
public readonly Dictionary<String, INamedValueInfo> ExtensionNamedValues = new Dictionary<String, INamedValueInfo>(StringComparer.OrdinalIgnoreCase);
@@ -445,8 +437,7 @@ public ParseContext(
445437
ITraceWriter trace,
446438
IEnumerable<INamedValueInfo> namedValues,
447439
IEnumerable<IFunctionInfo> functions,
448-
Boolean allowUnknownKeywords = false,
449-
Boolean allowCaseFunction = true)
440+
Boolean allowUnknownKeywords = false)
450441
{
451442
Expression = expression ?? String.Empty;
452443
if (Expression.Length > ExpressionConstants.MaxLength)
@@ -467,7 +458,6 @@ public ParseContext(
467458

468459
LexicalAnalyzer = new LexicalAnalyzer(Expression);
469460
AllowUnknownKeywords = allowUnknownKeywords;
470-
AllowCaseFunction = allowCaseFunction;
471461
}
472462

473463
private class NoOperationTraceWriter : ITraceWriter

‎src/Sdk/WorkflowParser/Conversion/WorkflowTemplateConverter.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1828,7 +1828,7 @@ private static BasicExpressionToken ConvertToIfCondition(
18281828
var node = default(ExpressionNode);
18291829
try
18301830
{
1831-
node = expressionParser.CreateTree(condition, null, namedValues, functions, allowCaseFunction: context.AllowCaseFunction) as ExpressionNode;
1831+
node = expressionParser.CreateTree(condition, null, namedValues, functions) as ExpressionNode;
18321832
}
18331833
catch (Exception ex)
18341834
{

0 commit comments

Comments
 (0)