[Naxxramas] - Heigan the Unclean's Eruption can do damage twice to the player

[TheSCREWEDSoftware]

Triage

Issue linked from CC: chromiecraft/chromiecraft#9135

Triage Notes:

• Be level 80
• .cheat god
• .go xyz 2778 -3693 274 533
• Stay where you got TP'd and start the fight with
• Look at your combat logs when Eruption does happen and see

chromiecraft/chromiecraft#9135 (comment)

This may be due to the trigger objects being close enough together to hit multiple given certain positions. On official servers, the trigger objects are purely visual and aren't actually casting the Eruption spell, that's being cast by Heigan himself so this issue is avoided, but on CC/AC the objects are the ones being made to cast the Eruption.

Similiar issue as: #25383

Original Post Below:

---

Current Behaviour

Sometimes the casts hit twice, and sometimes they hit once.

Expected Behaviour

Eruptions should only hit once.

Source

https://wowgaming.altervista.org/aowow/?spell=29371
https://www.wowhead.com/wotlk/spell=29371/eruption

Steps to reproduce the problem

1. Start Heigan fight
2. Move around the room as Eruptions happen
3. Sometimes they double tap, and sometimes single

Extra Notes

No real idea how to trigger 1 vs 2. It's not like the issue we had back in Ony, where cracks in the floor would proc 2 hits.

Customizations

No response

AC rev. hash/commit

chromiecraft@686aafd

Operating system

Ubuntu 22.04

Modules

• mod-1v1-arena
• mod-ah-bot
• mod-anticheat
• mod-arena-3v3-solo-queue
• mod-arena-replay
• mod-bg-item-reward
• mod-breaking-news-override
• mod-cfbg
• mod-chat-transmitter
• mod-chromie-xp
• mod-chromiecraft-smartstone
• mod-costumes
• mod-cta-switch
• mod-desertion-warnings
• mod-dmf-switch
• mod-duel-reset
• mod-eluna
• mod-evade-logging
• mod-instanced-worldbosses
• mod-ip-tracker
• mod-low-level-arena
• mod-low-level-rbg
• mod-multi-client-check
• mod-npc-spectator
• mod-progression-system
• mod-pvp-quests
• mod-pvp-titles
• mod-pvpstats-announcer
• mod-queue-list-cache
• mod-rdf-expansion
• mod-transmog
• mod-weekend-xp
• mod-zone-difficulty
• lua-CarbonCopy
• lua-eventScripts
• lua-ExchangeNpc
• lua-LevelUpReward
• lua-RecruitAFriend
• lua-SendAndBind
• lua-TempAnnouncements
• lua-Zonecheck

Server

ChromieCraft

[EricksOliveira]

I don't think it's unique to Spell. Several other Spellbooks have the same problem. I tried adding a delay, and even then sometimes it generates two ticks that shouldn't be there. The problem, as discussed here: #25048, might be related.

[heyitsbench]

It's unrelated. The root issue here is due to the trigger creatures casting the damaging spell, when Heigan should be the one casting it.