fix

Author: aidenybai

packages/react-doctor/tests/colorize-by-score.test.ts

@@ -0,0 +1,46 @@
+import { describe, expect, it } from "vitest";
+import { colorizeByScore } from "../src/utils/colorize-by-score.js";
+
+describe("colorizeByScore", () => {
+  it("returns a string for high scores", () => {
+    const result = colorizeByScore("Great", 90);
+    expect(typeof result).toBe("string");
+    expect(result).toContain("Great");
+  });
+
+  it("returns a string for medium scores", () => {
+    const result = colorizeByScore("OK", 60);
+    expect(typeof result).toBe("string");
+    expect(result).toContain("OK");
+  });
+
+  it("returns a string for low scores", () => {
+    const result = colorizeByScore("Critical", 30);
+    expect(typeof result).toBe("string");
+    expect(result).toContain("Critical");
+  });
+
+  it("does not throw at good threshold boundary (75)", () => {
+    expect(() => colorizeByScore("text", 75)).not.toThrow();
+    expect(() => colorizeByScore("text", 74)).not.toThrow();
+    expect(colorizeByScore("text", 75)).toContain("text");
+    expect(colorizeByScore("text", 74)).toContain("text");
+  });
+
+  it("does not throw at ok threshold boundary (50)", () => {
+    expect(() => colorizeByScore("text", 50)).not.toThrow();
+    expect(() => colorizeByScore("text", 49)).not.toThrow();
+    expect(colorizeByScore("text", 50)).toContain("text");
+    expect(colorizeByScore("text", 49)).toContain("text");
+  });
+
+  it("handles score of zero", () => {
+    const result = colorizeByScore("zero", 0);
+    expect(result).toContain("zero");
+  });
+
+  it("handles perfect score", () => {
+    const result = colorizeByScore("perfect", 100);
+    expect(result).toContain("perfect");
+  });
+});

packages/react-doctor/tests/combine-diagnostics.test.ts

@@ -0,0 +1,71 @@
+import { describe, expect, it } from "vitest";
+import type { Diagnostic, ReactDoctorConfig } from "../src/types.js";
+import { combineDiagnostics, computeJsxIncludePaths } from "../src/utils/combine-diagnostics.js";
+
+const createDiagnostic = (overrides: Partial<Diagnostic> = {}): Diagnostic => ({
+  filePath: "src/app.tsx",
+  plugin: "react-doctor",
+  rule: "test-rule",
+  severity: "warning",
+  message: "test message",
+  help: "test help",
+  line: 1,
+  column: 1,
+  category: "Test",
+  ...overrides,
+});
+
+describe("computeJsxIncludePaths", () => {
+  it("returns undefined for empty include paths", () => {
+    expect(computeJsxIncludePaths([])).toBeUndefined();
+  });
+
+  it("filters to only JSX/TSX files", () => {
+    const paths = ["src/app.tsx", "src/utils.ts", "src/Button.jsx", "src/config.js"];
+    const result = computeJsxIncludePaths(paths);
+    expect(result).toEqual(["src/app.tsx", "src/Button.jsx"]);
+  });
+
+  it("returns empty array when no JSX/TSX files exist", () => {
+    const paths = ["src/utils.ts", "src/config.js"];
+    const result = computeJsxIncludePaths(paths);
+    expect(result).toEqual([]);
+  });
+});
+
+describe("combineDiagnostics", () => {
+  it("merges lint and dead code diagnostics", () => {
+    const lintDiagnostics = [createDiagnostic({ rule: "lint-rule" })];
+    const deadCodeDiagnostics = [createDiagnostic({ rule: "dead-code-rule" })];
+
+    const result = combineDiagnostics(lintDiagnostics, deadCodeDiagnostics, "/tmp", true, null);
+    expect(result).toHaveLength(2);
+    expect(result[0].rule).toBe("lint-rule");
+    expect(result[1].rule).toBe("dead-code-rule");
+  });
+
+  it("returns empty array when both inputs are empty in diff mode", () => {
+    const result = combineDiagnostics([], [], "/tmp", true, null);
+    expect(result).toEqual([]);
+  });
+
+  it("applies config filtering when userConfig is provided", () => {
+    const diagnostics = [
+      createDiagnostic({ plugin: "react", rule: "no-danger" }),
+      createDiagnostic({ plugin: "react-doctor", rule: "no-giant-component" }),
+    ];
+    const config: ReactDoctorConfig = {
+      ignore: { rules: ["react/no-danger"] },
+    };
+
+    const result = combineDiagnostics(diagnostics, [], "/tmp", true, config);
+    expect(result).toHaveLength(1);
+    expect(result[0].rule).toBe("no-giant-component");
+  });
+
+  it("skips config filtering when userConfig is null", () => {
+    const diagnostics = [createDiagnostic(), createDiagnostic()];
+    const result = combineDiagnostics(diagnostics, [], "/tmp", true, null);
+    expect(result).toHaveLength(2);
+  });
+});

packages/react-doctor/tests/find-monorepo-root.test.ts

@@ -0,0 +1,33 @@
+import path from "node:path";
+import { describe, expect, it } from "vitest";
+import { findMonorepoRoot, isMonorepoRoot } from "../src/utils/find-monorepo-root.js";
+
+const FIXTURES_DIRECTORY = path.resolve(import.meta.dirname, "fixtures");
+
+describe("isMonorepoRoot", () => {
+  it("returns true for a directory with pnpm-workspace.yaml or workspaces", () => {
+    const nestedWorkspaces = path.join(FIXTURES_DIRECTORY, "nested-workspaces");
+    expect(isMonorepoRoot(nestedWorkspaces)).toBe(true);
+  });
+
+  it("returns false for a non-monorepo project", () => {
+    const basicReact = path.join(FIXTURES_DIRECTORY, "basic-react");
+    expect(isMonorepoRoot(basicReact)).toBe(false);
+  });
+
+  it("returns false for a nonexistent directory", () => {
+    expect(isMonorepoRoot("/nonexistent/path")).toBe(false);
+  });
+});
+
+describe("findMonorepoRoot", () => {
+  it("returns null when no monorepo root exists above directory", () => {
+    expect(findMonorepoRoot("/tmp")).toBeNull();
+  });
+
+  it("finds monorepo root from a nested workspace package", () => {
+    const nestedPackage = path.join(FIXTURES_DIRECTORY, "nested-workspaces", "packages", "ui");
+    const monorepoRoot = findMonorepoRoot(nestedPackage);
+    expect(monorepoRoot).toBe(path.join(FIXTURES_DIRECTORY, "nested-workspaces"));
+  });
+});