fmt

Author: aidenybai

action.yml

@@ -20,6 +20,9 @@ inputs:
   github-token:
     description: "GitHub token for posting PR comments. When set on pull_request events, findings are posted as a PR comment."
     required: false
+  fail-on:
+    description: "Exit with error code on diagnostics: error, warning, none"
+    default: "error"
   node-version:
     description: "Node.js version to use"
     default: "20"
@@ -43,8 +46,9 @@ runs:
         INPUT_PROJECT: ${{ inputs.project }}
         INPUT_DIFF: ${{ inputs.diff }}
         INPUT_GITHUB_TOKEN: ${{ inputs.github-token }}
+        INPUT_FAIL_ON: ${{ inputs.fail-on }}
       run: |
-        FLAGS=""
+        FLAGS="--fail-on $INPUT_FAIL_ON"
         if [ "$INPUT_VERBOSE" = "true" ]; then FLAGS="$FLAGS --verbose"; fi
         if [ -n "$INPUT_PROJECT" ]; then FLAGS="$FLAGS --project $INPUT_PROJECT"; fi
         if [ -n "$INPUT_DIFF" ]; then FLAGS="$FLAGS --diff $INPUT_DIFF"; fi
@@ -56,12 +60,15 @@ runs:
         fi
 
     - id: score
+      if: always()
       shell: bash
       env:
         INPUT_DIRECTORY: ${{ inputs.directory }}
       run: |
-        SCORE=$(npx -y react-doctor@latest "$INPUT_DIRECTORY" --score 2>/dev/null || echo "")
-        echo "score=$SCORE" >> "$GITHUB_OUTPUT"
+        SCORE=$(npx -y react-doctor@latest "$INPUT_DIRECTORY" --score 2>/dev/null | tail -1 | tr -d '[:space:]')
+        if [[ -n "$SCORE" && "$SCORE" =~ ^[0-9]+$ ]]; then
+          echo "score=$SCORE" >> "$GITHUB_OUTPUT"
+        fi
 
     - if: ${{ inputs.github-token != '' && github.event_name == 'pull_request' }}
       uses: actions/github-script@v7

packages/react-doctor/src/cli.ts

@@ -9,6 +9,7 @@ import type {
   Diagnostic,
   DiffInfo,
   EstimatedScoreResult,
+  FailOnLevel,
   ReactDoctorConfig,
   ScanOptions,
 } from "./types.js";
@@ -37,8 +38,23 @@ interface CliFlags {
   ami: boolean;
   project?: string;
   diff?: boolean | string;
+  failOn: string;
 }
 
+const VALID_FAIL_ON_LEVELS = new Set<FailOnLevel>(["error", "warning", "none"]);
+
+const isValidFailOnLevel = (level: string): level is FailOnLevel =>
+  VALID_FAIL_ON_LEVELS.has(level as FailOnLevel);
+
+const shouldFailForDiagnostics = (
+  diagnostics: Diagnostic[],
+  failOnLevel: FailOnLevel,
+): boolean => {
+  if (failOnLevel === "none") return false;
+  if (failOnLevel === "warning") return diagnostics.length > 0;
+  return diagnostics.some((diagnostic) => diagnostic.severity === "error");
+};
+
 const exitWithFixHint = () => {
   logger.break();
   logger.log("Cancelled.");
@@ -129,6 +145,7 @@ const program = new Command()
   .option("--diff [base]", "scan only files changed vs base branch")
   .option("--offline", "skip telemetry (anonymous, not stored, only used to calculate score)")
   .option("--no-ami", "skip Ami-related prompts")
+  .option("--fail-on <level>", "exit with error code on diagnostics: error, warning, none", "none")
   .option("--fix", "open Ami to auto-fix all issues")
   .action(async (directory: string, flags: CliFlags) => {
     const isScoreOnly = flags.score;
@@ -203,6 +220,18 @@ const program = new Command()
         }
       }
 
+      const resolvedFailOn =
+        program.getOptionValueSource("failOn") === "cli"
+          ? flags.failOn
+          : (userConfig?.failOn ?? flags.failOn);
+      const effectiveFailOn: FailOnLevel = isValidFailOnLevel(resolvedFailOn)
+        ? resolvedFailOn
+        : "none";
+
+      if (shouldFailForDiagnostics(allDiagnostics, effectiveFailOn)) {
+        process.exitCode = 1;
+      }
+
       if (flags.fix) {
         openAmiToFix(resolvedDirectory);
       }

packages/react-doctor/src/plugin/constants.ts

@@ -212,6 +212,12 @@ export const GOOGLE_FONTS_PATTERN = /fonts\.googleapis\.com/;
 
 export const POLYFILL_SCRIPT_PATTERN = /polyfill\.io|polyfill\.min\.js|cdn\.polyfill/;
 
+export const EXECUTABLE_SCRIPT_TYPES = new Set([
+  "text/javascript",
+  "application/javascript",
+  "module",
+]);
+
 export const APP_DIRECTORY_PATTERN = /\/app\//;
 
 export const ROUTE_HANDLER_FILE_PATTERN = /\/route\.(tsx?|jsx?)$/;

packages/react-doctor/src/plugin/rules/nextjs.ts

@@ -1,6 +1,7 @@
 import {
   APP_DIRECTORY_PATTERN,
   EFFECT_HOOK_NAMES,
+  EXECUTABLE_SCRIPT_TYPES,
   GOOGLE_FONTS_PATTERN,
   INTERNAL_PAGE_PATH_PATTERN,
   MUTATING_ROUTE_SEGMENTS,
@@ -267,6 +268,11 @@ export const nextjsNoNativeScript: Rule = {
     JSXOpeningElement(node: EsTreeNode) {
       if (node.name?.type !== "JSXIdentifier" || node.name.name !== "script") return;
 
+      const typeAttribute = findJsxAttribute(node.attributes ?? [], "type");
+      const typeValue =
+        typeAttribute?.value?.type === "Literal" ? typeAttribute.value.value : null;
+      if (typeof typeValue === "string" && !EXECUTABLE_SCRIPT_TYPES.has(typeValue)) return;
+
       context.report({
         node,
         message:

packages/react-doctor/src/scan.ts

@@ -496,19 +496,21 @@ export const scan = async (
           return lintDiagnostics;
         } catch (error) {
           didLintFail = true;
-          const errorMessage = error instanceof Error ? error.message : String(error);
-          const isNativeBindingError = errorMessage.includes("native binding");
-
-          if (isNativeBindingError) {
-            lintSpinner?.fail(
-              `Lint checks failed — oxlint native binding not found (Node ${process.version}).`,
-            );
-            logger.dim(
-              `  Upgrade to Node ${OXLINT_NODE_REQUIREMENT} or run: npx -p oxlint@latest react-doctor@latest`,
-            );
-          } else {
-            lintSpinner?.fail("Lint checks failed (non-fatal, skipping).");
-            logger.error(errorMessage);
+          if (!options.scoreOnly) {
+            const errorMessage = error instanceof Error ? error.message : String(error);
+            const isNativeBindingError = errorMessage.includes("native binding");
+
+            if (isNativeBindingError) {
+              lintSpinner?.fail(
+                `Lint checks failed — oxlint native binding not found (Node ${process.version}).`,
+              );
+              logger.dim(
+                `  Upgrade to Node ${OXLINT_NODE_REQUIREMENT} or run: npx -p oxlint@latest react-doctor@latest`,
+              );
+            } else {
+              lintSpinner?.fail("Lint checks failed (non-fatal, skipping).");
+              logger.error(errorMessage);
+            }
           }
           return [];
         }
@@ -527,8 +529,10 @@ export const scan = async (
             return knipDiagnostics;
           } catch (error) {
             didDeadCodeFail = true;
-            deadCodeSpinner?.fail("Dead code detection failed (non-fatal, skipping).");
-            logger.error(String(error));
+            if (!options.scoreOnly) {
+              deadCodeSpinner?.fail("Dead code detection failed (non-fatal, skipping).");
+              logger.error(String(error));
+            }
             return [];
           }
         })()

packages/react-doctor/src/types.ts

@@ -1,3 +1,5 @@
+export type FailOnLevel = "error" | "warning" | "none";
+
 export type Framework = "nextjs" | "vite" | "cra" | "remix" | "gatsby" | "expo" | "react-native" | "unknown";
 
 export interface ProjectInfo {
@@ -163,4 +165,5 @@ export interface ReactDoctorConfig {
   deadCode?: boolean;
   verbose?: boolean;
   diff?: boolean | string;
+  failOn?: FailOnLevel;
 }