dalec/imgconfig_test.go at main · project-dalec/dalec · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
package dalec

import (
	"testing"

	"gotest.tools/v3/assert"
	"gotest.tools/v3/assert/cmp"
)

func TestMergeSpecImage(t *testing.T) {
	t.Run("nil spec image returns empty config", func(t *testing.T) {
		spec := &Spec{}
		cfg := MergeSpecImage(spec, "foo")
		assert.Check(t, cmp.DeepEqual(cfg, &ImageConfig{}))
	})

	t.Run("spec image with no target returns spec image", func(t *testing.T) {
		spec := &Spec{
			Image: &ImageConfig{
				Entrypoint: "/bin/sh",
				Cmd:        "-c",
				User:       "1000",
				WorkingDir: "/app",
				StopSignal: "SIGTERM",
			},
		}
		cfg := MergeSpecImage(spec, "foo")
		assert.Check(t, cmp.Equal(cfg.Entrypoint, "/bin/sh"))
		assert.Check(t, cmp.Equal(cfg.Cmd, "-c"))
		assert.Check(t, cmp.Equal(cfg.User, "1000"))
		assert.Check(t, cmp.Equal(cfg.WorkingDir, "/app"))
		assert.Check(t, cmp.Equal(cfg.StopSignal, "SIGTERM"))
	})

	t.Run("target overrides user", func(t *testing.T) {
		spec := &Spec{
			Image: &ImageConfig{
				User: "1000",
			},
			Targets: map[string]Target{
				"azlinux3": {
					Image: &ImageConfig{
						User: "999",
					},
				},
			},
		}
		cfg := MergeSpecImage(spec, "azlinux3")
		assert.Check(t, cmp.Equal(cfg.User, "999"))
	})

	t.Run("target sets user when spec has none", func(t *testing.T) {
		spec := &Spec{
			Targets: map[string]Target{
				"azlinux3": {
					Image: &ImageConfig{
						User: "999",
					},
				},
			},
		}
		cfg := MergeSpecImage(spec, "azlinux3")
		assert.Check(t, cmp.Equal(cfg.User, "999"))
	})

	t.Run("spec user preserved when target does not set it", func(t *testing.T) {
		spec := &Spec{
			Image: &ImageConfig{
				User: "1000",
			},
			Targets: map[string]Target{
				"azlinux3": {
					Image: &ImageConfig{
						Cmd: "echo hello",
					},
				},
			},
		}
		cfg := MergeSpecImage(spec, "azlinux3")
		assert.Check(t, cmp.Equal(cfg.User, "1000"))
	})

	t.Run("target overrides all string fields", func(t *testing.T) {
		spec := &Spec{
			Image: &ImageConfig{
				Entrypoint: "/bin/old",
				Cmd:        "old",
				WorkingDir: "/old",
				StopSignal: "SIGINT",
				Base:       "old:latest",
				User:       "root",
			},
			Targets: map[string]Target{
				"t1": {
					Image: &ImageConfig{
						Entrypoint: "/bin/new",
						Cmd:        "new",
						WorkingDir: "/new",
						StopSignal: "SIGTERM",
						Base:       "new:latest",
						User:       "nobody",
					},
				},
			},
		}
		cfg := MergeSpecImage(spec, "t1")
		assert.Check(t, cmp.Equal(cfg.Entrypoint, "/bin/new"))
		assert.Check(t, cmp.Equal(cfg.Cmd, "new"))
		assert.Check(t, cmp.Equal(cfg.WorkingDir, "/new"))
		assert.Check(t, cmp.Equal(cfg.StopSignal, "SIGTERM"))
		assert.Check(t, cmp.Equal(cfg.Base, "new:latest"))
		assert.Check(t, cmp.Equal(cfg.User, "nobody"))
	})

	t.Run("target env appends to spec env", func(t *testing.T) {
		spec := &Spec{
			Image: &ImageConfig{
				Env: []string{"A=1"},
			},
			Targets: map[string]Target{
				"t1": {
					Image: &ImageConfig{
						Env: []string{"B=2"},
					},
				},
			},
		}
		cfg := MergeSpecImage(spec, "t1")
		assert.Check(t, cmp.DeepEqual(cfg.Env, []string{"A=1", "B=2"}))
	})

	t.Run("target volumes merge with spec volumes", func(t *testing.T) {
		spec := &Spec{
			Image: &ImageConfig{
				Volumes: map[string]struct{}{"/data": {}},
			},
			Targets: map[string]Target{
				"t1": {
					Image: &ImageConfig{
						Volumes: map[string]struct{}{"/logs": {}},
					},
				},
			},
		}
		cfg := MergeSpecImage(spec, "t1")
		assert.Check(t, cmp.Len(cfg.Volumes, 2))
		_, hasData := cfg.Volumes["/data"]
		_, hasLogs := cfg.Volumes["/logs"]
		assert.Check(t, hasData)
		assert.Check(t, hasLogs)
	})

	t.Run("target labels merge with spec labels", func(t *testing.T) {
		spec := &Spec{
			Image: &ImageConfig{
				Labels: map[string]string{"a": "1"},
			},
			Targets: map[string]Target{
				"t1": {
					Image: &ImageConfig{
						Labels: map[string]string{"b": "2"},
					},
				},
			},
		}
		cfg := MergeSpecImage(spec, "t1")
		assert.Check(t, cmp.Len(cfg.Labels, 2))
		assert.Check(t, cmp.Equal(cfg.Labels["a"], "1"))
		assert.Check(t, cmp.Equal(cfg.Labels["b"], "2"))
	})

	t.Run("nonexistent target key returns spec image unchanged", func(t *testing.T) {
		spec := &Spec{
			Image: &ImageConfig{
				User:       "1000",
				Entrypoint: "/bin/sh",
			},
		}
		cfg := MergeSpecImage(spec, "nonexistent")
		assert.Check(t, cmp.Equal(cfg.User, "1000"))
		assert.Check(t, cmp.Equal(cfg.Entrypoint, "/bin/sh"))
	})
}