26.3 Antalya port - Alternative syntax for cluster functions#1640
26.3 Antalya port - Alternative syntax for cluster functions#1640ianton-ru wants to merge 16 commits intoantalya-26.3from
Conversation
…tive_syntax 26.1 Antalya port - Alternative syntax for cluster functions
…e_for_partitioning 26.1 Antalya port - Timezone for partitioning
…nquoted_timezone Fix unquoted timezone in sorting key
ianton-ru
changed the title
…_initiator Antalya 26.1: Fix remote initiator host name
…itiator_improvements Antalya 26.1: Remote initiator improvements
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88842054aa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pure_storage->renameInMemory(new_table_id); | ||
| return; |
There was a problem hiding this comment.
StorageObjectStorageCluster::renameInMemory returns after renaming only pure_storage, but pure_storage is always present, so the wrapper's own storage_id is never updated. After RENAME TABLE, calls that read StorageObjectStorageCluster::getStorageID() can still see the old identifier, which can break catalog/dependency logic that relies on the storage object reporting its current name.
Useful? React with 👍 / 👎.
src/Storages/IStorageCluster.cpp
Outdated
| static pcg64 rng(randomSeed()); | ||
| size_t shard_num = rng() % host_addresses.size(); |
There was a problem hiding this comment.
The function keeps a process-wide static pcg64 and advances it on each call. When multiple queries use object_storage_remote_initiator concurrently, they race on this shared RNG state, which is undefined behavior in C++. This can lead to flaky host selection and hard-to-diagnose concurrency issues; use thread_local RNG or guard access with synchronization.
Useful? React with 👍 / 👎.
…rser' into frontport/antalya-26.3/alternative_syntax
3 participants
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Frontports for Antalya 26.3
CI/CD Options
Exclude tests:
Regression jobs to run: