Skip to content

[all]: Add namespaceOverride Value to all Charts that missing it#1214

Merged
dloewen2 merged 6 commits intoCloudPirates-io:mainfrom
KosrenDQ:main
Apr 10, 2026
Merged

[all]: Add namespaceOverride Value to all Charts that missing it#1214
dloewen2 merged 6 commits intoCloudPirates-io:mainfrom
KosrenDQ:main

Conversation

@KosrenDQ
Copy link
Copy Markdown
Contributor

@KosrenDQ KosrenDQ commented Apr 9, 2026

Description of the change

Add the capability to override the namespace for each Chart and fixes some value errors in mongodb/rabbitmq-cluster-Operator Chart.

[all]: Add the namespaceOverride Value used in commons to all Charts that it not used yet.

[mongodb]:

  • Fix wrong value .Value.imagePullSecret to .Value.global.imagePullSecret in spec.template.spec.imagePullSecret of statefulset-arbiter.yaml
  • Fix wrong value .Value.imagePullSecret to .Value.global.imagePullSecret in spec.template.spec.imagePullSecret of statefulset-hidden.yaml
  • Fix wrong value .Value.initContainer.Resources to .Value.initContainer.resources in spec.template.spec.initContainers[0] of statefulset-hidden.yaml
  • Add missing Value extraInitContainers
  • Add missing Value customLivenessProbe
  • Add missing Value customReadinessProbe
  • Add missing Value customStartupProbe
  • Add missing Value config.existingConfigmapKey

[rabbitmq-cluster-Operator]:

  • Add Value namespaceOverride to documentation

Benefits

All Charts can now be used in a multi-namespace system, such as with an Umbrella Chart.

Possible drawbacks

Not observed.

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md
  • Title of the pull request follows this pattern [<name_of_the_chart>] Descriptive title
  • All commits are signed and verified (required as of January 22, 2026 - see CONTRIBUTING.md)

KosrenDQ and others added 2 commits April 9, 2026 17:15
Signed-off-by: cloudpirates-bot <cloudpirates-bot@users.noreply.github.com>
@KosrenDQ
Copy link
Copy Markdown
Contributor Author

KosrenDQ commented Apr 9, 2026

I really appreciate that there's an alternative to Bitnami! 😄

@dloewen2 dloewen2 self-assigned this Apr 10, 2026
@dloewen2 dloewen2 self-requested a review April 10, 2026 10:27
@dloewen2
Copy link
Copy Markdown
Member

Hi @KosrenDQ,
thanks for the PR. This will definitely increase the quality of the charts.

I found two instances, where the namespaceOverride did not get included, could you please add them as well?

  1. Memcached Chart HttpRoute Resource
  2. TimescaleDB Chart Configmap Resource

Other than this the PR looks good to me.

@KosrenDQ
Copy link
Copy Markdown
Contributor Author

Hi @dloewen2,

thank you very much!
I have added the two missing overrides.

Copy link
Copy Markdown
Member

@dloewen2 dloewen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dloewen2 dloewen2 merged commit 39a029c into CloudPirates-io:main Apr 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants