[zookeeper] Add support for custom servers list#1220
Open
nenych wants to merge 1 commit intoCloudPirates-io:mainfrom
Open
[zookeeper] Add support for custom servers list#1220nenych wants to merge 1 commit intoCloudPirates-io:mainfrom
nenych wants to merge 1 commit intoCloudPirates-io:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
My changes allow overriding the servers list in the zookeeper config.
Benefits
We can create a custom list of servers that allows us to combine 2 helm releases for the migration purpose, or more importantly, we can create custom services with the ClusterIp instead of headless for static IPs in the topology. This allows us to have no downtime (or at least smaller) on the node pool update or something else.
Possible drawbacks
No behavior changes without setting the new value.
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.md