Sheffield | 26-Jan-ITP | Daniel Aderibigbe | Sprint 2 | Book libary

[Dan2Clouted]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Book libary project completed

[cjyuan]

Can you check if any of this general feedback can help you further improve your code?
https://github.com/cjyuan/Module-Data-Flows/blob/book-library-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

[Dan2Clouted]

Changes Made

• Fixed HTML validation issues (invalid input types, added lang, corrected <meta charset> placement, added proper <title>)
• Updated script to use ES modules and removed inline onclick in favour of addEventListener
• Removed duplicate/unnecessary code (extra render() call)
• Improved variable naming for clarity (e.g. titleInput, readCheckbox)
• Standardised data types (page count stored as a number)
• Simplified and improved input validation (removed null checks, added trimming, ensured valid values)
• Replaced .innerHTML with .textContent for safer DOM updates
• Removed unnecessary id attributes from dynamically created elements
• Improved naming consistency (toggleReadBtn, deleteBtn)
• Optimised table rendering by clearing it in one operation
• Fixed delete logic to ensure action completes before showing confirmation

Thank you for your review in advance!

[cjyuan]

Other changes look good.

[Dan2Clouted]

• Improved input validation and data handling (page count as a positive integer, trimmed inputs)
• Refactored DOM updates and event handling for cleaner and more maintainable code

[cjyuan]

Well done!