DataSourceLoader - Update DynamicClassBridge class to use renamed DynamicClass indexer in System.Linq.Dynamic.Core v1.6.8#683
Open
AlisherAmonulloev wants to merge 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the DynamicClassBridge class to dynamically retrieve the indexer name from the System.Linq.Dynamic.Core.DynamicClass type instead of hardcoding it as "Item". This change makes the code more flexible and adaptable to potential variations in the DynamicClass implementation.
Key Changes
- Replaced hardcoded indexer method lookup with dynamic retrieval based on a static field
- Added reflection logic to read the
IndexerNamefield from the DynamicClass type - Included fallback to "Item" if the field is not found or null
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mpreyskurantov
added
dependencies
AlisherAmonulloev
changed the title
AlisherAmonulloev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caused by / v1.6.8: