Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion appengine-java11/gaeinfo/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ Copyright 2019 Google LLC
<dependency>
<groupId>org.thymeleaf</groupId>
<artifactId>thymeleaf</artifactId>
<version>3.1.2.RELEASE</version>
<version>3.1.4.RELEASE</version>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-critical critical

The version 3.1.4.RELEASE does not exist in Maven Central. Starting with version 3.1.3, Thymeleaf has changed its versioning scheme and removed the .RELEASE suffix. The correct version to use is 3.1.4. Additionally, while this update addresses the SSTI vulnerabilities mentioned in the PR, please be aware that the application's templates (e.g., index.html) use th:utext to render user-controlled data such as headers and cookies, which introduces a significant Cross-Site Scripting (XSS) vulnerability. It is strongly recommended to switch to th:text for automatic HTML escaping.

Suggested change
<version>3.1.4.RELEASE</version>
<version>3.1.4</version>

<scope>provided</scope>
</dependency>
</dependencies>
Expand Down