fix(functions): migrate imagemagick sample to sharp and improve test stability#4288
Open
angelcaamal wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
Open
fix(functions): migrate imagemagick sample to sharp and improve test stability#4288angelcaamal wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
angelcaamal wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
Conversation
…stability - Replaced 'gm' with 'sharp' for image blurring to fix EPIPE errors. - Fixed temporary file deletion to prevent memory leaks in the blurring function. - Refactored the test suite to use try...finally, ensuring the Functions Framework process is always killed to release ports (fixes EADDRINUSE). - Improved test error logging for easier debugging.
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the image blurring function from ImageMagick (using the gm library) to the sharp library. The changes include updating the dependencies in package.json, refactoring the core logic in index.js to handle temporary files with sharp, and enhancing the test suite with better error handling. The review feedback correctly identifies that the engines field in package.json must be updated to support sharp's Node.js requirements. Additionally, there are several recommendations to improve code quality by removing dead code (commented-out lines), fixing inconsistent language in comments, and ensuring consistent async/await usage during file cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes Internal: b/503436089
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.