Fix type inference for parent scopes and method definitions with receivers#4062
Open
vinistock wants to merge 3 commits intorubydex_adoption_feature_branchfrom
Open
Fix type inference for parent scopes and method definitions with receivers#4062vinistock wants to merge 3 commits intorubydex_adoption_feature_branchfrom
vinistock wants to merge 3 commits intorubydex_adoption_feature_branchfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In the original Ruby LSP indexer, we did not handle the resolution of parent scopes used in definitions. For example:
Similarly this example
We also did not handle method definition receivers correctly, which don't advance the lexical scope, but modify the type of
self. For example:Implementation
There are two main parts to fix, which can be found in the first commit:
def self.fooas a singleton entry in the node context nesting. Method receivers don't advance the lexical scope and do not influence constant resolution. They only influence the type ofselfThen I made the necessary adjustments on the type inferrer.
Automated Tests
The last commit includes a bunch of tests verifying that we're correctly handling these cases in definition and hover.