Skip to content

fix(sdk): drop auth headers from public firewall API endpoint #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
John-David Dalton (jdalton) merged 1 commit into from
Apr 15, 2026
Merged

fix(sdk): drop auth headers from public firewall API endpoint #581

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion src/socket-sdk-class.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,10 +957,27 @@ export class SocketSdk {
const results = await Promise.allSettled(
components.map(async ({ purl }) => {
const urlPath = `/${encodeURIComponent(purl)}`
// Public endpoint — copy all headers except Authorization
// (case-insensitive per RFC 7230 §3.2), keep agent/signal/timeout.
const publicHeaders: Record<string, string> = {
__proto__: null,
} as unknown as Record<string, string>
const srcHeaders = this.#reqOptions.headers as
| Record<string, string>
| undefined
if (srcHeaders) {
const keys = Object.keys(srcHeaders)
for (let i = 0, { length } = keys; i < length; i += 1) {
const key = keys[i]!
if (key.toLowerCase() !== 'authorization') {
publicHeaders[key] = srcHeaders[key]!
}
}
}
const response = await createGetRequest(
SOCKET_FIREWALL_API_URL,
urlPath,
this.#reqOptions,
{ ...this.#reqOptions, headers: publicHeaders },
)
if (!isResponseOk(response)) return undefined
const json = await getResponseJson(response)
Expand Down