refactor: rename scripts/*.mjs to *.mts for native TypeScript#584
Open
John-David Dalton (jdalton) wants to merge 3 commits intomainfrom
Open
refactor: rename scripts/*.mjs to *.mts for native TypeScript#584John-David Dalton (jdalton) wants to merge 3 commits intomainfrom
John-David Dalton (jdalton) wants to merge 3 commits intomainfrom
Conversation
John-David Dalton (jdalton)
force-pushed
the
refactor/scripts-mts
branch
2 times, most recently
from
588b41b to
4badfaf
Compare
Bill Li (billxinli)
approved these changes
Apr 15, 2026
The previous commit renamed scripts/*.mjs to *.mts but left behind stale .mjs extensions in cross-file imports, spawn args, comments, and workflow path triggers. Also renames .config/esbuild.config.mjs to .mts to match the import in build.mts.
- Add type annotations to esbuild plugin params (PluginBuild, BuildResult, etc.) - Use bracket notation for index signature access (process.env, parseArgs values) - Add null/undefined guards for possibly-undefined values - Fix catch clauses to use `catch (e)` with proper type narrowing - Add `as const` for string literal types (format, platform, sourcemap) - Add @types/semver for semver type declarations - Fix openapi-typescript transform callback signatures - Handle exactOptionalPropertyTypes correctly in return types - Fix babel traverse/parser version mismatch with proper casts
John-David Dalton (jdalton)
force-pushed
the
refactor/scripts-mts
branch
from
7eb36f5 to
6b8c56c
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 25.9.0 supports .mts natively. Rename all scripts from .mjs to .mts for explicit ESM TypeScript.