Skip to content

feat: add tsgo type checking to check runner #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
John-David Dalton (jdalton) wants to merge 6 commits into from
Closed

feat: add tsgo type checking to check runner #586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
841f7cf
chore: enable eslint/curly rule to require braces on all control flow
jdalton Apr 15, 2026
5898220
chore: update @typescript/native-preview to 7.0.0-dev.20260415.1
jdalton Apr 15, 2026
383d483
feat: add "typecheck" script using tsgo (typescript-go)
jdalton Apr 15, 2026
985a439
revert: remove standalone typecheck script (will add to check flow)
jdalton Apr 15, 2026
4d0e1d3
fix: use word boundaries in AWS key detection to avoid base64 false p…
jdalton Apr 15, 2026
36b64b8
feat: add tsgo type checking to check runner (lint + format + typecheck)
jdalton Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .git-hooks/pre-push
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,10 +168,10 @@ while read local_ref local_sha remote_ref remote_sha; do
ERRORS=$((ERRORS + 1))
fi

# AWS keys.
if echo "$file_text" | grep -iqE '(aws_access_key|aws_secret|AKIA[0-9A-Z]{16})'; then
# AWS keys (word-boundary match to avoid false positives in base64 data).
if echo "$file_text" | grep -iqE '(aws_access_key|aws_secret|\bAKIA[0-9A-Z]{16}\b)'; then
printf "${RED}✗ BLOCKED: Potential AWS credentials found in: %s${NC}\n" "$file"
echo "$file_text" | grep -niE '(aws_access_key|aws_secret|AKIA[0-9A-Z]{16})' | head -3
echo "$file_text" | grep -niE '(aws_access_key|aws_secret|\bAKIA[0-9A-Z]{16}\b)' | head -3
ERRORS=$((ERRORS + 1))
fi

Expand Down
2 changes: 1 addition & 1 deletion .oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"suspicious": "error"
},
"rules": {
"eslint/curly": "off",
"eslint/curly": ["error", "all"],
"eslint/no-await-in-loop": "off",
"eslint/no-console": "off",
"eslint/no-control-regex": "off",
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
"@sveltejs/acorn-typescript": "1.0.8",
"@types/babel__traverse": "7.28.0",
"@types/node": "24.9.2",
"@typescript/native-preview": "7.0.0-dev.20250926.1",
"@typescript/native-preview": "7.0.0-dev.20260415.1",
"@vitest/coverage-v8": "4.0.3",
"acorn": "8.15.0",
"del": "8.0.1",
Expand Down
66 changes: 33 additions & 33 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions src/socket-sdk-class.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -979,13 +979,17 @@ export class SocketSdk {
urlPath,
{ ...this.#reqOptions, headers: publicHeaders },
)
if (!isResponseOk(response)) return undefined
if (!isResponseOk(response)) {
return undefined
}
const json = await getResponseJson(response)
return json as unknown as SocketArtifact
}),
)
for (const settled of results) {
if (settled.status === 'rejected' || !settled.value) continue
if (settled.status === 'rejected' || !settled.value) {
continue
}
packages.push(SocketSdk.#normalizeArtifact(settled.value, publicPolicy))
}
return {
Expand Down
16 changes: 12 additions & 4 deletions test/unit/coverage-non-error-paths.test.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,9 @@ describe('SocketSdk - checkMalware batch normalize with publicPolicy', () => {
const result = await client.checkMalware(components)

expect(result.success).toBe(true)
if (!result.success) return
if (!result.success) {
return
}
expect(result.data).toHaveLength(count)
const pkg = result.data[0]!

Expand Down Expand Up @@ -892,7 +894,9 @@ describe('SocketSdk - uploadManifestFiles edge cases', () => {
])

expect(result.success).toBe(false)
if (result.success) return
if (result.success) {
return
}
expect(result.error).toBe('No readable manifest files found')
// The cause should contain truncation for >5 files
const cause = (result as { cause?: string }).cause ?? ''
Expand All @@ -917,7 +921,9 @@ describe('SocketSdk - uploadManifestFiles edge cases', () => {
])

expect(result.success).toBe(false)
if (result.success) return
if (result.success) {
return
}
expect(result.error).toBe('Custom validation error')
// When errorCause is not redundant with errorMessage, it should be included
const typedResult = result as { cause?: string }
Expand All @@ -942,7 +948,9 @@ describe('SocketSdk - uploadManifestFiles edge cases', () => {
])

expect(result.success).toBe(false)
if (result.success) return
if (result.success) {
return
}
expect(result.error).toBe('Custom validation error')
// Redundant cause should be filtered out by filterRedundantCause
const typedResult = result as { cause?: string }
Expand Down
48 changes: 36 additions & 12 deletions test/unit/socket-sdk-check-malware.test.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,9 @@ describe('SocketSdk - checkMalware', () => {
])

expect(result.success).toBe(true)
if (!result.success) return
if (!result.success) {
return
}
const pkg = result.data[0]!
expect(pkg.alerts).toHaveLength(1)
expect(pkg.alerts[0]!.type).toBe('malware')
Expand Down Expand Up @@ -95,7 +97,9 @@ describe('SocketSdk - checkMalware', () => {
])

expect(result.success).toBe(true)
if (!result.success) return
if (!result.success) {
return
}
const pkg = result.data[0]!
expect(pkg.alerts).toHaveLength(1)
expect(pkg.alerts[0]!.type).toBe('criticalCVE')
Expand Down Expand Up @@ -126,7 +130,9 @@ describe('SocketSdk - checkMalware', () => {
])

expect(result.success).toBe(true)
if (!result.success) return
if (!result.success) {
return
}
const pkg = result.data[0]!
expect(pkg.alerts).toEqual([])
expect(pkg.name).toBe('lodash')
Expand Down Expand Up @@ -154,7 +160,9 @@ describe('SocketSdk - checkMalware', () => {
])

expect(result.success).toBe(true)
if (!result.success) return
if (!result.success) {
return
}
expect(result.data[0]!.alerts).toEqual([])
})

Expand Down Expand Up @@ -184,7 +192,9 @@ describe('SocketSdk - checkMalware', () => {
])

expect(result.success).toBe(true)
if (!result.success) return
if (!result.success) {
return
}
const pkg = result.data[0]!
expect(pkg.namespace).toBe('@types')
expect(pkg.name).toBe('node')
Expand Down Expand Up @@ -214,7 +224,9 @@ describe('SocketSdk - checkMalware', () => {
])

expect(result.success).toBe(true)
if (!result.success) return
if (!result.success) {
return
}
expect(result.data).toHaveLength(2)
expect(result.data[0]!.alerts).toEqual([])
expect(result.data[1]!.alerts).toHaveLength(1)
Expand All @@ -239,7 +251,9 @@ describe('SocketSdk - checkMalware', () => {
])

expect(result.success).toBe(true)
if (!result.success) return
if (!result.success) {
return
}
expect(result.data).toHaveLength(1)
expect(result.data[0]!.name).toBe('good')
})
Expand All @@ -254,7 +268,9 @@ describe('SocketSdk - checkMalware', () => {
])

expect(result.success).toBe(true)
if (!result.success) return
if (!result.success) {
return
}
expect(result.data).toEqual([])
})
})
Expand All @@ -279,7 +295,9 @@ describe('SocketSdk - checkMalware', () => {
const result = await getClient().checkMalware(makeComponents(count))

expect(result.success).toBe(true)
if (!result.success) return
if (!result.success) {
return
}
expect(result.data).toHaveLength(count)
expect(result.data[0]!.alerts).toHaveLength(1)
expect(result.data[0]!.alerts[0]!.type).toBe('malware')
Expand Down Expand Up @@ -310,7 +328,9 @@ describe('SocketSdk - checkMalware', () => {
const result = await getClient().checkMalware(makeComponents(count))

expect(result.success).toBe(true)
if (!result.success) return
if (!result.success) {
return
}
expect(result.data[0]!.alerts).toEqual([])
})

Expand All @@ -324,7 +344,9 @@ describe('SocketSdk - checkMalware', () => {
)

expect(result.success).toBe(false)
if (result.success) return
if (result.success) {
return
}
expect(result.status).toBe(401)
})

Expand Down Expand Up @@ -367,7 +389,9 @@ describe('SocketSdk - checkMalware', () => {
const result = await getClient().checkMalware(makeComponents(count))

expect(result.success).toBe(true)
if (!result.success) return
if (!result.success) {
return
}
const pkg = result.data[0]!
expect(pkg.alerts).toHaveLength(1)
expect(pkg.alerts[0]!.type).toBe('malware')
Expand Down
Loading