Skip to content

LPM CAN I/O changes + update URLs#661

Open
kwillis01 wants to merge 5 commits intoTexasInstruments:masterfrom
kwillis01:am62-changes
Open

LPM CAN I/O changes + update URLs#661
kwillis01 wants to merge 5 commits intoTexasInstruments:masterfrom
kwillis01:am62-changes

Conversation

@kwillis01
Copy link
Copy Markdown
Contributor

No description provided.

Reword CAN wakeup section to be more readable for users. Remove UART from
section name since CAN is the wakeup source and CAN UART is the bank of
pins the CAN is in.

Signed-off-by: Kendall Willis <k-willis@ti.com>
Reword Partial IO section to make it more readable. Additionally, update
Partial IO expected output for SDK 12.0.

Signed-off-by: Kendall Willis <k-willis@ti.com>
In SDK 12.0, ethtool is used to enable wakeup from CAN. Update the LPM
documentation where necessary to reflect this change.

Signed-off-by: Kendall Willis <k-willis@ti.com>
In SDK 12.0, the referenced Main UART wakeup code has been changed style
wise, but the functionality is still the same from SDK 11.2. Therefore,
update the referenced code to be inline with SDK 12.0 implementation.

Signed-off-by: Kendall Willis <k-willis@ti.com>
Update all links to reference SDK 12.00.00.08.

Signed-off-by: Kendall Willis <k-willis@ti.com>
Comment on lines 50 to +53
The reference implementation in this SDK implements Partial I/O as a
poweroff state. On poweroff, Linux ti_sci driver checks the potential
Partial I/O wakeup sources for being enabled. If one of the wakeup
sources is found to be enabled, Partial I/O is entered instead of poweroff.
poweroff state. On poweroff, Linux ti_sci driver checks if any potential
Partial I/O wakeup sources are enabled. If one of the wakeup sources is
enabled, Partial I/O is entered instead of poweroff.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This SDK implements Partial I/O as a power-off state. The Linux ti_sci
driver will enter Partial I/O if any Partial I/O wakeup sources are preset.

Comment on lines +55 to +57
Wakeup sources mcu_mcan0 and mcu_mcan1 have been configured for Partial
I/O. For more information on enabling CAN, refer to
:ref:`CAN I/O Daisy Chain<pm_wakeup_sources_can>`.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wakeup sources mcu_mcan0 and mcu_mcan1 have support for Partial
I/O. For more information about enabling CAN, see
:ref:CAN I/O Daisy Chain<pm_wakeup_sources_can>.

Comment on lines +1005 to +1009
CAN wakeup is enabled by default for the AM62X LP-SK EVM. Otherwise,
the device tree overlay
`k3-am62x-sk-lpm-wkup-sources.dtso <https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/tree/arch/arm64/boot/dts/ti/k3-am62x-sk-lpm-wkup-sources.dtso?h=12.00.00.07>`__
is needed for testing CAN wakeup. Refer to
:ref:`How to enable DT overlays<howto_dt_overlays>` for details.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean "otherwise" here? Is it enabled or not? If it is, and the overlay is a required part of it then it would be better to say:

Suggested change
CAN wakeup is enabled by default for the AM62X LP-SK EVM. Otherwise,
the device tree overlay
`k3-am62x-sk-lpm-wkup-sources.dtso <https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/tree/arch/arm64/boot/dts/ti/k3-am62x-sk-lpm-wkup-sources.dtso?h=12.00.00.07>`__
is needed for testing CAN wakeup. Refer to
:ref:`How to enable DT overlays<howto_dt_overlays>` for details.
CAN wakeup is enabled by default for the AM62X LP-SK EVM using the device tree overlay
`k3-am62x-sk-lpm-wkup-sources.dtso <https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/tree/arch/arm64/boot/dts/ti/k3-am62x-sk-lpm-wkup-sources.dtso?h=12.00.00.07>`__
Refer to :ref:`How to enable DT overlays<howto_dt_overlays>` for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants