[core] Clean up field-level options when dropping columns#7659
Open
qingwei727 wants to merge 1 commit intoapache:masterfrom
Open
[core] Clean up field-level options when dropping columns#7659qingwei727 wants to merge 1 commit intoapache:masterfrom
qingwei727 wants to merge 1 commit intoapache:masterfrom
Conversation
When dropping a column that has field-level options (e.g. fields.xxx.default-value), SchemaValidation.validateFieldsPrefix() would fail because the options still reference the dropped column. This fix removes fields.<droppedColumn>.* options during dropColumn in SchemaManager.generateTableSchema().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix IllegalArgumentException: Field xxx can not be found in table schema when dropping a column that has field-level options (e.g. fields.xxx.default-value).
SchemaManager.generateTableSchema() removes the column from the field list but leaves its fields..* entries in options, causing SchemaValidation.validateFieldsPrefix() to fail. This fix removes those orphaned options during DropColumn processing.
Tests
SchemaManagerTest#testDropColumnCleansUpFieldOptions — creates a table with fields.extra_col.default-value, drops the column, and verifies both the column and its options are removed.