fix(console): regional Projects API for service toggles + full ApiSer…#2976
fix(console): regional Projects API for service toggles + full ApiSer…#2976HarshMN2345 wants to merge 11 commits intomainfrom
Conversation
Greptile SummaryThis PR migrates service/webhook SDK calls to
Confidence Score: 4/5Safe to merge after fixing the "Placeholder" description text in updateSecurity.svelte, which will render as literal UI copy. One P1 finding (literal "Placeholder" text exposed in UI) blocks a clean merge; the P2 analytics misattribution in updateProtocols.svelte should also be addressed but is not a functional breakage. src/routes/(console)/project-[region]-[project]/settings/webhooks/[webhook]/updateSecurity.svelte (placeholder description text) and src/routes/(console)/project-[region]-[project]/settings/updateProtocols.svelte (analytics event name). Important Files Changed
Reviews (8): Last reviewed commit: "add enable and disable all to protocol u..." | Re-trigger Greptile |
Co-authored-by: Matej Bačo <matejbaco2000@gmail.com>
src/lib/stores/project-services.ts
Outdated
| { label: 'Functions', method: ApiService.Functions, value: null }, | ||
| { label: 'GraphQL', method: ApiService.Graphql, value: null }, | ||
| { label: 'Messaging', method: ApiService.Messaging, value: null } | ||
| ] satisfies Service[] |
There was a problem hiding this comment.
We are missing Migrations
Let's also ask AI to sort the list alphabetically
src/lib/stores/project-services.ts
Outdated
| { | ||
| label: 'Messaging', | ||
| method: ApiService.Messaging, | ||
| value: project.serviceStatusForMessaging |
There was a problem hiding this comment.
Missing migrations I think
|
|
||
| try { | ||
| await sdk.forConsole.projects.updateServiceStatusAll({ | ||
| await sdk.forConsoleIn($project.region).projects.updateServiceStatusAll({ |
There was a problem hiding this comment.
We no longer have updateServiceStatusAll. We need to loop them, and do "updateServiceStatus".
|
|
||
| try { | ||
| await sdk.forConsole.projects.updateServiceStatus({ | ||
| await sdk.forConsoleIn($project.region).projects.updateServiceStatus({ |
There was a problem hiding this comment.
We need new SDK and use project SDK, not projects.
src/routes/(console)/project-[region]-[project]/settings/webhooks/[webhook]/regenerate.svelte
Outdated
Show resolved
Hide resolved
| <svelte:fragment slot="aside"> | ||
| <div> | ||
| <Secret label="Key" copyEvent="signature" bind:value={$webhook.signatureKey} /> | ||
| <Secret label="Key" copyEvent="signature" bind:value={$webhook.secret} /> |
There was a problem hiding this comment.
You can no longer read secret - you only see it once after creating it, or after updating it
…vice list
What does this PR do?
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)