Skip {types-,}protobuf upgrades in Renovate#452
Conversation
We [previously ignored these in Dependabot][1]; should do the same in Renovate. #451 is failing because it's attempting to bump these. [1]: 328d768#diff-dd4fbda47e51f1e35defb9275a9cd9c212ecde0b870cba89ddaaae65c5f3cd28L13-L14
.github/renovate.json5
Outdated
| "types-protobuf" | ||
| ], | ||
| // We manage these dependencies ourselves. | ||
| "lockFileMaintenance": { |
There was a problem hiding this comment.
I think we can remove this so just any type of update is disabled for them, in case we add to a subproject some day
There was a problem hiding this comment.
do you mean going from:
"lockFileMaintenance": {
"enabled": false
}to:
"enabled": false?
I'm still a tad confused by the comment here (and in connect-python) about only bumping prod dependencies when necessary, but matching both prod and "optional" dependencies?: https://github.com/connectrpc/connect-python/blob/f188e7d0452be8a1ad04e308754852c76ee62c4d/renovate.json#L16-L23
There was a problem hiding this comment.
Yeah that's what I meant. One point is the enablement is a setting, while the others are matchers. So the setting to "disable all updates for the matched dependencies" is the plain enabled: false IIUC.
The optional dependencies point is admittedly cargo culted from some templates. In a hypothetical future where we supported extras in any of the libraries, those would be in optional-dependencies and would be the same scheme as production dependencies. Since we don't have any, indeed it's confusing - maybe it's better to remove that and add it when/if the time comes.
There was a problem hiding this comment.
426da3d. thanks for explaining; that makes more sense to me.
2 participants
We previously ignored these in Dependabot; should do the same in Renovate. #451 is failing because it's attempting to bump these.
Not entirely sure on the syntax here; I'm trying to follow the connect-python approach with otel: https://github.com/connectrpc/connect-python/blob/f188e7d0452be8a1ad04e308754852c76ee62c4d/renovate.json#L31-L37.