fix(CodeSigningPlugin): sign assets at processAssets ANALYSE stage before REPORT#1379
Open
JhohellsDL wants to merge 1 commit intocallstack:mainfrom
Open
fix(CodeSigningPlugin): sign assets at processAssets ANALYSE stage before REPORT#1379JhohellsDL wants to merge 1 commit intocallstack:mainfrom
JhohellsDL wants to merge 1 commit intocallstack:mainfrom
Conversation
🦋 Changeset detectedLatest commit: dc3d3fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@JhohellsDL is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1377
CodeSigningPluginwas signing bundles incompiler.hooks.assetEmitted,which fires after
processAssetscompletes. When usingwithZephyr(),Zephyr captures and uploads assets at
PROCESS_ASSETS_STAGE_REPORT(5000)— before
assetEmittedfires — resulting in unsigned bundles being uploadedto the CDN, making
verifyScriptSignature: 'strict'ineffective.Changes
assetEmittedtoprocessAssetsatPROCESS_ASSETS_STAGE_ANALYSE(2000), before Zephyr'sREPORTstage (5000)compilation.updateAsset()instead of reading/writing from disk
chunkFilenamesSet andemithook — no longer needed sincesigning iterates
compilation.chunksdirectly insideprocessAssetsREPORTstage## Behaviorsection explaining the signing stageTesting
REPORTstage confirmingassets are already signed when captured
withZephyr()— bundlesuploaded to CDN now contain the signature and
verifyScriptSignature: 'strict'works correctly