Avoid unneeded shutdown timer on already closed connection#125
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR prevents the SOCKS server from invoking endConnection() when the incoming connection is no longer writable, avoiding an unnecessary 3s forced-shutdown timer in failure/cancellation scenarios (notably when the client is already closing during handshake).
Changes:
- Guard
endConnection()inServer::onConnection()withConnectionInterface::isWritable(). - Update unit tests to stub
isWritable()where the rejection path is exercised. - Add a regression test covering the “already closed / not writable” scenario.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/Server.php |
Adds an isWritable() guard before calling endConnection() on SOCKS handshake failure. |
tests/ServerTest.php |
Extends mocks with isWritable() and adds a regression test for the closed-connection failure path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset updates the SOCKS server to avoid calling
endConnection()when the connection is no longer writable. This avoids creating a useless 3s shutdown timer when the SOCKS handshake fails on a connection that is already closing.Builds on top of #121