Skip to content

SCIM jit edits#24600

Open
akristen wants to merge 22 commits intodocker:mainfrom
akristen:scim-jit-edits
Open

SCIM jit edits#24600
akristen wants to merge 22 commits intodocker:mainfrom
akristen:scim-jit-edits

Conversation

@akristen
Copy link
Copy Markdown
Contributor

@akristen akristen commented Apr 1, 2026

just a lot of stuff that got out of hand idk. it started out as a nice reorg of provision and turned into a nightmare of my own making

@akristen akristen self-assigned this Apr 1, 2026
@akristen akristen added the area/admin Relates to Docker Admin label Apr 1, 2026
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 1, 2026

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit f29bdff
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/69dd3af7b801af000810d5e5
😎 Deploy Preview https://deploy-preview-24600--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

akristen added 3 commits April 1, 2026 10:59
…ce it contained two topics; moved domain management into provision since sso has its own instructions in setup
@akristen
Copy link
Copy Markdown
Contributor Author

akristen commented Apr 1, 2026

/review

@docker-agent
Copy link
Copy Markdown
Contributor

docker-agent bot commented Apr 1, 2026

PR Review Failed — The review agent encountered an error and could not complete the review. View logs.

@dvdksn
Copy link
Copy Markdown
Contributor

dvdksn commented Apr 2, 2026

/review

docker-agent[bot]

This comment was marked as resolved.

@akristen
Copy link
Copy Markdown
Contributor Author

akristen commented Apr 9, 2026

/review

docker-agent[bot]

This comment was marked as resolved.

@akristen
Copy link
Copy Markdown
Contributor Author

akristen commented Apr 9, 2026

/review

docker-agent[bot]

This comment was marked as resolved.

docker-agent[bot]

This comment was marked as resolved.

@akristen akristen requested a review from aevesdocker April 9, 2026 18:44
Use Hugo source paths with .md or _index.md for cross-references from admin
overview, organization pages, and company users. Align SSO, SCIM, roles,
enforce sign-in, Settings Management, domains, billing paths, and related
targets with content/manuals layout.

Made-with: Cursor
Point billing FAQs, payment method, 3D Secure, and tax certificate cross-links
to Hugo source paths under content/manuals/billing and subscription.

Made-with: Cursor
Point Create a Docker ID to content/manuals/accounts/create-account.md.

Made-with: Cursor
Use /manuals/admin/company/_index.md for Hugo ref resolution.

Made-with: Cursor
akristen and others added 4 commits April 13, 2026 11:12
Use /manuals/... and /reference/api/hub/latest.md paths for Hugo ref
resolution on JIT, provision-scim, and migrate-scim.

Made-with: Cursor
Use /manuals/ paths for security announcements, access tokens, JIT, FAQs,
and troubleshoot; /reference/api/hub/latest.md for Hub API; repair
security-announcements URL typo and Markdown link punctuation in
troubleshoot-sso.

Made-with: Cursor
Point domain and SSO connect anchors to /manuals/...; align CLI reference
links with /reference/cli/...md forms used elsewhere in manuals.

Made-with: Cursor
@akristen
Copy link
Copy Markdown
Contributor Author

/review

@akristen akristen removed the request for review from aevesdocker April 13, 2026 16:31
docker-agent[bot]

This comment was marked as resolved.

Point SCIM section links at scim/_index.md instead of nonexistent scim.md.
Route supported-attributes anchor to provision-scim.md. Fix group mapping
link in admin user management guide to use /manuals/... path.

Made-with: Cursor
@akristen
Copy link
Copy Markdown
Contributor Author

/review

Copy link
Copy Markdown
Contributor

@docker-agent docker-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

This PR reorganizes SCIM and provisioning documentation with no critical issues found.

Changes reviewed:

  • 42 files changed (primarily SCIM/JIT provisioning reorganization)
  • File moves: troubleshoot-provisioning.md and troubleshoot-sso.md moved into their respective feature directories
  • Deletion: enterprise/troubleshoot/_index.md (empty directory index)
  • Link updates throughout to reflect new file locations
  • Front matter formatting improvements (consistent YAML indentation)

Verification results:
All internal links verified and working correctly. The reorganization properly updates link targets to match the new file structure.

Copy link
Copy Markdown
Contributor

@docker-agent docker-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🔴 CRITICAL

Found 1 critical issue that needs attention:

  • Missing redirect alias for moved file (will cause 404 errors)

- /security/for-admins/provisioning/group-mapping/
weight: 30
- /security/for-admins/provisioning/scim/group-mapping/
weight: 20
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing redirect alias for moved file

The file group-mapping.md was moved from content/manuals/enterprise/security/provisioning/ to content/manuals/enterprise/security/provisioning/scim/.

After Hugo strips the /manuals prefix:

  • Old published URL: /enterprise/security/provisioning/group-mapping/
  • New published URL: /enterprise/security/provisioning/scim/group-mapping/

The aliases list in the front matter includes legacy redirects but is missing a redirect from the immediate previous location. Users visiting the old URL will get a 404.

Fix: Add this alias to the front matter:

aliases:
- /admin/company/settings/group-mapping/
- /admin/organization/security-settings/group-mapping/
- /docker-hub/group-mapping/
- /security/for-admins/group-mapping/
- /security/for-admins/provisioning/scim/group-mapping/
- /enterprise/security/provisioning/group-mapping/  # Add this line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/admin Relates to Docker Admin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants