engine: fix versioning by propagating TAGPREFIX#410
Open
wojiushixiaobai wants to merge 1 commit intodocker:mainfrom
Open
engine: fix versioning by propagating TAGPREFIX#410wojiushixiaobai wants to merge 1 commit intodocker:mainfrom
TAGPREFIX#410wojiushixiaobai wants to merge 1 commit intodocker:mainfrom
Conversation
Signed-off-by: 吴小白 <296015668@qq.com>
thaJeztah
reviewed
Apr 15, 2026
| ARG GO_VERSION="1.26.2" | ||
| ARG GO_IMAGE_VARIANT="bookworm" | ||
|
|
||
| ARG TAGPREFIX="docker-" |
Member
There was a problem hiding this comment.
Wondering if it should be closer to the default, but with a prefix, e.g. docker-v[0-9]*
(no strong opinion, just thinking out loud 😅)
cc @vvoland
Member
There was a problem hiding this comment.
(not sure if the * glob would work if set through the arg)
Contributor
Author
There was a problem hiding this comment.
packaging/hack/scripts/gen-ver.sh
Lines 18 to 32 in 928861f
If we set TAGPREFIX="docker-v[0-9]*", the resulting tagregex becomes docker-v[0-9]*v[0-9]*, which won't match our tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
gen-ver.shscript (or the version generation logic) fails to capture the correct version because it defaults to atagregexofv[0-9]*.As shown in the build logs, this causes the versioning logic to either miss the official tags or fail to strip thedocker-prefix: