Add OpenTelemetry forwarder infrastructure#9136
Add OpenTelemetry forwarder infrastructure#9136rajkumar-rangaraj wants to merge 4 commits intomainfrom
Conversation
- Add OpenTelemetry.OutOfProcess.Forwarder.Configuration 0.1.0-beta.1 package version - Add ENABLE_OTEL conditional compilation: when set, adds package reference and defines BUILDING_OTEL preprocessor symbol - Set ENABLE_OTEL in generate-dev-sln.ps1 for dev builds - Fix missing newline at end of generate-dev-sln.ps1
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="'$(ENABLE_OTEL)' != ''"> | ||
| <PackageReference Include="OpenTelemetry.OutOfProcess.Forwarder.Configuration" /> |
There was a problem hiding this comment.
How large is this package and its dependencies? If it's not very big, maybe we can reference it unconditionally.
There was a problem hiding this comment.
Both the current and dependent packages together are small, < 100KB.
There was a problem hiding this comment.
Let's just add these unconditionally then. Otherwise, we'll have to have two builds. We may need to add this package to the central feed.
There was a problem hiding this comment.
Updated the PR to reference the package unconditionally and removed the ENABLE_OTEL gating.
Regarding the central feed, I may not have access to add the package there. Could you help with that, or point me to who can?
| <PackageReference Include="OpenTelemetry.OutOfProcess.Forwarder.Configuration" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="'$(DIAGNOSTICS_REPO_ROOT)' == ''"> |
There was a problem hiding this comment.
I want to confirm the target branch of .NET 10+. You will not need this in 8 or 9 correct?
There was a problem hiding this comment.
That's right. Please note that OpenTelemetry.OutOfProcess.Forwarder.Configuration is currently built with net9.0. In the upcoming beta, it will be updated to net10.
Address review feedback: remove ENABLE_OTEL gating so the package is always referenced and BUILDING_OTEL is always defined, avoiding the need for two separate builds.
rajkumar-rangaraj
force-pushed
the
rajrang/otel-infrastructure
branch
from
9fe18aa to
f52f7cd
Compare
2 participants
Summary
Adds the infrastructure for OpenTelemetry out-of-process forwarder integration. This is PR 1 of 6 see #9135 for the full feature overview.
Changes
OpenTelemetry.OutOfProcess.Forwarder.Configuration0.1.0-beta.1 package versionBUILDING_OTELpreprocessor define, both gated onENABLE_OTELMSBuild propertyENABLE_OTEL=truefor dev builds; fix missing newline at EOFHow it works
When
ENABLE_OTELis set (to any non-empty value), the build:OpenTelemetry.OutOfProcess.Forwarder.ConfigurationBUILDING_OTELconstant for conditional compilationAll subsequent OTel code will be guarded with
#if BUILDING_OTEL, ensuring zero impact on the default build.Testing
ENABLE_OTEL: no change in behavior, package not referencedENABLE_OTEL=true: package restored,BUILDING_OTELdefined