Simplify emscripten_futex_wait after recent changes. NFC#26693
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Apr 16, 2026
Merged
Simplify emscripten_futex_wait after recent changes. NFC#26693sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
sbc100
changed the title
sbc100
force-pushed
the
simplify_futex_wait
branch
3 times, most recently
from
3c0d0a7 to
7c99bc1
Compare
tlively
reviewed
Apr 16, 2026
sbc100
force-pushed
the
simplify_futex_wait
branch
from
7c99bc1 to
76c8f2b
Compare
tlively
approved these changes
Apr 16, 2026
sbc100
force-pushed
the
simplify_futex_wait
branch
from
76c8f2b to
9e590d2
Compare
As a followup to emscripten-core#26691 and emscripten-core#26659 we can simplify `emscripten_futex_wait` even further removing all references to `_emscripten_process_dlopen_queue`. Instead we move the call to emscripten_yield() until after the atomic.wait operation (or the skipping of it). `emscripten_yield()` then takes care of calling `_emscripten_process_dlopen_queue` as needed.
sbc100
force-pushed
the
simplify_futex_wait
branch
from
9e590d2 to
6de2e37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a followup to #26691 and #26659 we can simplify
emscripten_futex_waiteven further removing all references to_emscripten_process_dlopen_queue.Instead we move the call to
emscripten_yield()until after theatomic.waitoperation (or the skipping of it).emscripten_yield()then takes care of calling_emscripten_process_dlopen_queueas needed.