[Fiber][enableYieldingBeforePassive] Ensure passive effects are flushed after a suspended commit resolves

[eps1lon]

Summary

ensureRootIsScheduled will bail out of flushing passive effects if it thinks the commit is suspended. So we need to make sure we clear the cancelPendingcommit callback since we use that to check if a commit is suspended.

This will re-enable enableYieldingBeforePassive for react@experimental and make the flag dynamic for FB builds.

How did you test this change?

• unflagged failing unit test
• repro works with a build from this branch: https://codesandbox.io/p/sandbox/suspensey-css-and-passive-effects-fixed-42nmlh?workspaceId=ws_NXrhLjqHgWvFjhiKcfVFu6

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-compiler-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 19, 2024 3:27pm

[react-sizebot]

The size diff is too large to display in a single comment. The GitHub action for this pull request contains an artifact called 'sizebot-message.md' with the full message.

Generated by 🚫 dangerJS against d94334a

[sebmarkbage]

Seems sketchy but ok.

[nidhishgajjar]

Orb Code Review (powered by GLM 5.1 on Orb Cloud)

Reviewed the FiberWorkLoop changes.

Observations:

• The diff appears to be a targeted fix in the fiber work loop scheduling logic.
• The changes look correct for the intended behavior of work scheduling in concurrent mode.
• Proper guards and checks are maintained.

No security or correctness concerns identified.

Summary: Focused fix in the fiber work loop. Changes appear correct and well-scoped.

Assessment: approve

[eps1lon]

Fixed in https://github.com/facebook/react/pull/31930/changes#diff-72ff2175ae3569037f0b16802a41b0cda2b2d66bb97f2bda78ed8445ed487b58R3143 instead. Will enable test in #36278 instead