Python: Add exception, reachability, and other kinds of modelling#21668
Open
Python: Add exception, reachability, and other kinds of modelling#21668
Conversation
tausbn
force-pushed
the
tausbn/python-port-shared-infrastructure
branch
from
c51a476 to
c70427d
Compare
The implementation is essentially the same as the one from `BasicBlockWithPointsTo`, with the main difference being that this one uses the exception machinery we just added (and some extensions added in this commit).
Adds support for finding instances, and adds things like a `BaseException` convenience class.
Used for queries where we mention the class of a literal in the alert message.
Adds `if False: ...` and `if typing.TYPE_CHECKING: ...` to the set of nodes that are unlikely to be reachable.
Adds `maybeUndefined` to the reachability module, modelling which names/variables may be undefined at runtime. The approach is very close to the one used in points-to, though it of course relies on our new modelling of exceptions/reachability instead.
tausbn
force-pushed
the
tausbn/python-port-shared-infrastructure
branch
from
c70427d to
ca59ca0
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces shared infrastructure in the Python dataflow internals to support upcoming query ports, including centralized exception-type modeling and reachability utilities.
Changes:
- Refactors
IncorrectExceptOrderto reuse a sharedExceptionTypesmodel instead of defining exception hierarchy logic locally. - Adds
ExceptionTypesandReachabilitymodules (and supporting predicates) toDataFlowDispatch.qllfor exception reasoning and reachability/undefined-name analysis. - Extends
DuckTypingwith new predicates for globally defined names and monkey-patched builtins.
Show a summary per file
| File | Description |
|---|---|
| python/ql/src/Exceptions/IncorrectExceptOrder.ql | Switches to shared exception-type infrastructure via ExceptionTypes. |
| python/ql/lib/semmle/python/dataflow/new/internal/DataFlowDispatch.qll | Adds new internal modules/predicates for exception hierarchy and reachability reasoning. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A grab bag of infrastructure that is needed for the next bunch of queries to be ported.
Should be reviewed commit-by-commit.