Skip to content

fix: rename resolve-pr-review-thread to resolve-pr-thread#231

Merged
jamesadevine merged 1 commit intomainfrom
fix/resolve-pr-thread-rename
Apr 16, 2026
Merged

fix: rename resolve-pr-review-thread to resolve-pr-thread#231
jamesadevine merged 1 commit intomainfrom
fix/resolve-pr-thread-rename

Conversation

@jamesadevine
Copy link
Copy Markdown
Collaborator

Closes #228

Summary

Standardises on resolve-pr-thread (the shorter, cleaner name matching AGENTS.md and README.md documentation) by renaming all occurrences of resolve-pr-review-thread across:

  • src/safeoutputs/resolve_pr_thread.rs
  • src/mcp.rs — MCP #[tool] registration, handler fn name, log message
  • src/execute.rs — executor dispatch match arm, debug logs
  • src/compile/common.rs — validation function key, error messages, test fixture strings

Docs (AGENTS.md, README.md, prompts) already used the correct name — no changes needed.

Clean break (no deprecation period) since the tool is new.

Standardise on the shorter, cleaner name matching AGENTS.md and README.md
documentation. Updated across:

- tool_result! macro name and config key lookup
- MCP tool registration and handler function
- Executor dispatch match arm
- Compile-time validation function and error messages
- All related tests

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Rust PR Review

Summary: Looks good — clean, complete rename with no issues found.

Findings

✅ What Looks Good

  • Rename is exhaustive: Zero remaining occurrences of resolve-pr-review-thread across the entire codebase. All four touch-points (mcp.rs, execute.rs, compile/common.rs, safeoutputs/resolve_pr_thread.rs) are consistently updated.
  • Macro-derived constants self-update: ALL_KNOWN_SAFE_OUTPUTS and WRITE_REQUIRING_SAFE_OUTPUTS are derived at compile time from ResolvePrThreadResult::NAME via the tool_names! / all_safe_output_names! macros, so no manual list update was needed — and none was missed.
  • Tests updated in lockstep: All four unit tests in compile/common.rs and the three in resolve_pr_thread.rs (test_result_has_correct_name, test_try_into_creates_result, test_serialized_json_contains_name) are updated to assert the new name. The test-suite will catch any future drift.
  • Documentation was already correct: AGENTS.md, README.md, and the prompt files already used resolve-pr-thread, so no doc churn needed.
  • No backward-compatibility risk: The tool is new and there's no deprecation period needed for a rename before first external adoption.

Generated by Rust PR Reviewer for issue #231 · ● 492.7K ·

@jamesadevine jamesadevine merged commit e1d3735 into main Apr 16, 2026
13 checks passed
@jamesadevine jamesadevine deleted the fix/resolve-pr-thread-rename branch April 16, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: reconcile resolve-pr-thread vs resolve-pr-review-thread naming

1 participant