Skip to content

refactor: move templates into src/data/ directory#235

Merged
jamesadevine merged 1 commit intomainfrom
refactor/move-templates-to-src
Apr 16, 2026
Merged

refactor: move templates into src/data/ directory#235
jamesadevine merged 1 commit intomainfrom
refactor/move-templates-to-src

Conversation

@jamesadevine
Copy link
Copy Markdown
Collaborator

Summary

Move pipeline templates from the top-level templates/ directory into src/data/ alongside ecosystem_domains.json, keeping injected content (templates, data files) separate from source code.

Changes

  • Move 4 template files: base.yml, 1es-base.yml, init-agent.md, threat-analysis.mdsrc/data/
  • Update test path in compiler_tests.rs
  • Update documentation in AGENTS.md (architecture tree + 3 path references)
  • Update workflow path filters in rust-tests.yml, rust-pr-reviewer.md, rust-pr-reviewer.lock.ymltemplates/** glob removed since src/** now covers them
  • Update workflow prompts in doc-freshness-check.md, red-team-security.md

Move pipeline templates from top-level templates/ into src/data/
alongside ecosystem_domains.json, keeping injected content separate
from source code. Update all include paths, documentation, workflow
path filters, and test references.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jamesadevine jamesadevine force-pushed the refactor/move-templates-to-src branch from 8ce405d to d9aa8ad Compare April 16, 2026 21:57
@jamesadevine jamesadevine merged commit ca46dc7 into main Apr 16, 2026
5 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Rust PR Review

Summary: Looks good — clean refactoring with all paths updated correctly and the build verified.

Findings

✅ What Looks Good

  • All include_str!() path math is correct: files in src/compile/ use ../data/<file>, src/init.rs uses data/<file> — verified by a successful cargo build with no errors
  • The templates/** path filter removal from workflow triggers is correct since src/** now covers those files
  • AGENTS.md architecture tree is now more accurate — it also adds the previously-missing ecosystem_domains.json entry, which is a nice bonus
  • Test path update in compiler_tests.rs (CARGO_MANIFEST_DIR/src/data/base.yml) is correct
  • No behavioral changes — pure file relocation using include_str! (compile-time embedding), so there's no runtime path resolution to worry about

Generated by Rust PR Reviewer for issue #235 · ● 429.2K ·

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant