Skip to content

feat(fdleak): added support for macos (darwin)#102

Merged
fredbi merged 1 commit intogo-openapi:masterfrom
fredbi:feat/fdleak-macos
Apr 18, 2026
Merged

feat(fdleak): added support for macos (darwin)#102
fredbi merged 1 commit intogo-openapi:masterfrom
fredbi:feat/fdleak-macos

Conversation

@fredbi
Copy link
Copy Markdown
Member

@fredbi fredbi commented Apr 17, 2026

Change type

Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update

Short description

Fixes

Full description

Checklist

  • I have signed all my commits with my name and email (see DCO. This does not require a PGP-signed commit
  • I have rebased and squashed my work, so only one commit remains
  • I have added tests to cover my changes.
  • I have properly enriched go doc comments in code.
  • I have properly documented any breaking change.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 83.14607% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.31%. Comparing base (1a12044) to head (3483c18).
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/fdleak/fdleak_darwin.go 82.97% 6 Missing and 2 partials ⚠️
internal/fdleak/fdleak_linux.go 83.33% 2 Missing and 2 partials ⚠️
internal/fdleak/fdleak_unsupported.go 0.00% 2 Missing ⚠️
internal/assertions/safety.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   91.32%   91.31%   -0.02%     
==========================================
  Files          94       97       +3     
  Lines       12226    12293      +67     
==========================================
+ Hits        11166    11225      +59     
- Misses        839      846       +7     
- Partials      221      222       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fredbi fredbi force-pushed the feat/fdleak-macos branch from ed7fe4a to f419f9c Compare April 18, 2026 07:18
This PR extends the NoFileDescriptorLeak assertion to support darwin,
in addition to linux.

NOTE: Windows OS remains unsupported for now

* doc: updated documentation and ROADMAP

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi fredbi force-pushed the feat/fdleak-macos branch from f419f9c to 3483c18 Compare April 18, 2026 07:24
@fredbi fredbi merged commit 737a67b into go-openapi:master Apr 18, 2026
23 checks passed
@fredbi fredbi deleted the feat/fdleak-macos branch April 18, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant