okhttp: enable TLS 1.3 on Android, retain TLS 1.2-only for desktop JVM#12763
Open
myksyr-tdy wants to merge 1 commit intogrpc:masterfrom
Open
okhttp: enable TLS 1.3 on Android, retain TLS 1.2-only for desktop JVM#12763myksyr-tdy wants to merge 1 commit intogrpc:masterfrom
myksyr-tdy wants to merge 1 commit intogrpc:masterfrom
Conversation
The ConnectionSpec used by OkHttpChannelBuilder had TLS 1.3 explicitly disabled since Dec 2020 due to a Conscrypt/SunJSSE incompatibility. However, this incompatibility does not affect Android. The previous code applied the TLS 1.2-only restriction unconditionally to all platforms. Regulatory impact: TLS 1.2 is classified as a legacy mechanism in ENISA Agreed Cryptographic Mechanisms v2.0 (April 2025), with TLS 1.3 listed as the recommended protocol. This limitation has been forcing all downstream components using grpc-okhttp on Android to operate with a legacy protocol, creating compliance friction with the EU Radio Equipment Directive (RED) and EU Cyber Resilience Act (CRA) certification requirements. Fixes: grpc#7431 (Android only) Fixes: grpc#7765 (Android only)
|
|
|
|
||
| ServerCredentials(SSLSocketFactory factory) { | ||
| this(factory, OkHttpChannelBuilder.INTERNAL_DEFAULT_CONNECTION_SPEC); | ||
| this(factory, OkHttpChannelBuilder.INTERNAL_LEGACY_CONNECTION_SPEC); |
There was a problem hiding this comment.
shouldnt it be OkHttpChannelBuilder.initialConnectionSpec() then?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ConnectionSpec used by OkHttpChannelBuilder had TLS 1.3 explicitly disabled since Dec 2020 due to a Conscrypt/SunJSSE incompatibility. However, this incompatibility does not affect Android. The previous code applied the TLS 1.2-only restriction unconditionally to all platforms.
Regulatory impact: TLS 1.2 is classified as a legacy mechanism in ENISA Agreed Cryptographic Mechanisms v2.0 (April 2025), with TLS 1.3 listed as the recommended protocol. This limitation has been forcing all downstream components using grpc-okhttp on Android to operate with a legacy protocol, creating compliance friction with the EU Radio Equipment Directive (RED) and EU Cyber Resilience Act (CRA) certification requirements.
Fixes: #7431 (Android only)
Fixes: #7765 (Android only)