api: Turn on RFC 3986 parsing by default and update javadoc.#12764
Open
jdcormie wants to merge 1 commit intogrpc:masterfrom
Open
api: Turn on RFC 3986 parsing by default and update javadoc.#12764jdcormie wants to merge 1 commit intogrpc:masterfrom
jdcormie wants to merge 1 commit intogrpc:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added discussion of ambiguity which is technically new with the RFC 3986 change. A target like
foo:8888didn't used to be ambiguous (if you believed the javadoc API contract) because it is not a "valid NameResolver-compliant" URI -- the path doesn't start with / and so java.net.URI considers it opaque, not hierarchical as required. Fortunately (???) ManagedChannelImplBuilder never enforced the !isOpaque() requirement mentioned in the javadoc and so this ambiguity isn't actually new in practice. gRPC C++ also appears to suffer from the same problem.Will not merge until the time is right!