Skip to content

feat(sistent): add Table component documentation#7610

Open
Sohamsig wants to merge 7 commits intolayer5io:masterfrom
Sohamsig:sistent-table-docs
Open

feat(sistent): add Table component documentation#7610
Sohamsig wants to merge 7 commits intolayer5io:masterfrom
Sohamsig:sistent-table-docs

Conversation

@Sohamsig
Copy link
Copy Markdown

@Sohamsig Sohamsig commented Apr 9, 2026

This PR adds documentation for the Table component in Sistent.

Added:

  • index.mdx
  • guidance.mdx
  • code.mdx

Also updated navigation for Table component.

Signed-off-by: Soham Babrekar <soham.babrekar@gmail.com>
@Sohamsig Sohamsig force-pushed the sistent-table-docs branch from f51f3b9 to 9b7a07a Compare April 9, 2026 17:32
@Sohamsig
Copy link
Copy Markdown
Author

Sohamsig commented Apr 10, 2026

@rishiraj38 Hi, I’ve completed the changes for this issue.
Deploy preview failed due to fork permissions, but all checks passed.
Could you please review when you get a chance? Thanks!

Copy link
Copy Markdown
Member

@rishiraj38 rishiraj38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to the other components present there; this, in my opinion, is not the correct implementation.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is the code ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This navigation is also incorrect.

@@ -0,0 +1,18 @@
---
title: Table
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn’t right; we have more fields here.

@rishiraj38 rishiraj38 removed the request for review from Rajesh-Nagarajan-11 April 10, 2026 19:09
@rishiraj38
Copy link
Copy Markdown
Member

@Sohamsig, will you be able to do this? I see you’re a first-time contributor so it might be a bit overwhelming.

Signed-off-by: Soham Babrekar <soham.babrekar@gmail.com>
@Sohamsig Sohamsig force-pushed the sistent-table-docs branch from 2fee297 to 582b087 Compare April 11, 2026 05:35
@Sohamsig
Copy link
Copy Markdown
Author

@rishiraj38 Yes, I've already addressed the comments and updated the PR.
Please let me know if anything else needs to be fixed. Thanks!

@Sohamsig Sohamsig requested a review from rishiraj38 April 11, 2026 05:43
Signed-off-by: Soham Babrekar <soham.babrekar@gmail.com>
Signed-off-by: Soham Babrekar <soham.babrekar@gmail.com>
Signed-off-by: Soham Babrekar <soham.babrekar@gmail.com>
Signed-off-by: Soham Babrekar <soham.babrekar@gmail.com>
Signed-off-by: Soham Babrekar <soham.babrekar@gmail.com>
@Sohamsig
Copy link
Copy Markdown
Author

Sohamsig commented Apr 11, 2026

@rishiraj38 Hi 👋
I’ve pushed the changes to fix the import issue, but the CI build is still failing with:
Can't resolve @sistent/components
I updated src/collections/sistent/components/table/index.mdx to use the local ConformanceTest-Table import, but it seems there may still be another reference or the build is expecting a different setup.

Could you please guide me on whether @sistent/components should be installed/linked, or if there are any other files I might have missed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants