fix(smi-table): optimize row rendering with memoized rows#7618
Open
Manishnemade12 wants to merge 1 commit intolayer5io:masterfrom
Open
fix(smi-table): optimize row rendering with memoized rows#7618Manishnemade12 wants to merge 1 commit intolayer5io:masterfrom
Manishnemade12 wants to merge 1 commit intolayer5io:masterfrom
Conversation
Signed-off-by: Manishnemade12 <mnemade140@gmail.com>
Author
|
@rishiraj38 Can you please review this pr |
rishiraj38
reviewed
Apr 11, 2026
Member
rishiraj38
left a comment
There was a problem hiding this comment.
Good catch on extracting TableRow to fix the state mutation!
One issue though: dynamically generating the tooltip IDs (react-tooltip-${rowIndex}) broke the tooltips on the checkmarks/crosses since those are still hardcoded to look for react-tooltip. Also, rendering a <Tooltip> component per row can causes severe DOM bloat.
Author
|
@rishiraj38 following changes i did as per your suggestion
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves the SMI table rendering performance issue by isolating row rendering and collapse state per row.
Closes : #7613
What changed
TableRowcomponent insrc/components/SMI-Table/index.js.TableRowwithReact.memo()to reduce unnecessary row re-renders.useState(false)) insideTableRow.Why this improves performance
Scope
src/components/SMI-Table/index.jsValidation