Improve Event page Performance#7621
Open
AnkitRewar11 wants to merge 2 commits intolayer5io:masterfrom
Open
Conversation
Signed-off-by: ankitrewar11 <ankitrewar11@gmail.com>
AnkitRewar11
force-pushed
the
fix/event-page-performance
branch
from
66217cf to
7cf252e
Compare
Signed-off-by: Ankit Rewar <171806101+AnkitRewar11@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the Events page performance and accessibility based on PageSpeed Insights recommendations from issue #6929.
Fixes #6929
What was wrong?
relattribute had a typo (oopenerinstead ofnoopener)widthandheightcausing layout shifts<main>landmark elementWhat did I fix?
aria-labelto all card links so screen readers can identify themrel="noreferrer noopener"typowidthandheightto event images to reduce CLS (layout shift)<main>landmark for better navigationrole="group"andaria-pressedto filter buttons for keyboard accessibilityLighthouse Score Improvements (Mobile)
Screenshot