fix(angular): allow float strokeWidth (and size)#4288
Open
undsoft wants to merge 1 commit intolucide-icons:mainfrom
Open
fix(angular): allow float strokeWidth (and size)#4288undsoft wants to merge 1 commit intolucide-icons:mainfrom
undsoft wants to merge 1 commit intolucide-icons:mainfrom
Conversation
2 tasks
Member
|
Hey @undsoft, As far as I can tell, this behaviour will already get resolved and then some more by #4253, which @swastik7805 unfortunately closed without further notice. I've reopened that PR and reverted the requested unwelcome changes to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4287
Description
Allows strokeWidth to be specific as float string, e.g.:
Previously this would get interpreted as
1.Note. This also allows
sizeto be specified as float, which is not useful.But I thought that there is no harm in that, so I didn't guard against it.
Before Submitting