Skip to content

fix(angular): allow float strokeWidth (and size)#4288

Open
undsoft wants to merge 1 commit intolucide-icons:mainfrom
undsoft:angular-allow-float-width
Open

fix(angular): allow float strokeWidth (and size)#4288
undsoft wants to merge 1 commit intolucide-icons:mainfrom
undsoft:angular-allow-float-width

Conversation

@undsoft
Copy link
Copy Markdown

@undsoft undsoft commented Apr 9, 2026

closes #4287

Description

Allows strokeWidth to be specific as float string, e.g.:

<svg lucideStar strokeWidth="1.2" />

Previously this would get interpreted as 1.

Note. This also allows size to be specified as float, which is not useful.
But I thought that there is no harm in that, so I didn't guard against it.

Before Submitting

@karsa-mistmere
Copy link
Copy Markdown
Member

Hey @undsoft,

As far as I can tell, this behaviour will already get resolved and then some more by #4253, which @swastik7805 unfortunately closed without further notice. I've reopened that PR and reverted the requested unwelcome changes to the lucide-react codebase, I'd much appreciate if you could review the changes there and see if you find them satisfactory. 🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Float values are not parsed in strokeWidth

2 participants