fix(database): add dbname parameter to postgres dsn

[sm-28601]

Description

This PR addresses the issue where the PostgreSQL DSN connection string in database/database.go was constructed without the dbname parameter. Without explicitly defining the dbname, PostgreSQL defaults to connecting to a database matching the operating user's name, which prevents the application from connecting to a dedicated database (e.g., mesherydb).

To fix this:

1. Added a Database field to the Options struct.
2. Updated the fmt.Sprintf for the DSN under the POSTGRES case to include dbname=%s.

This PR fixes #969

Signed commits

• Yes, I signed my commits.

[gemini-code-assist]

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

[Copilot]

Pull request overview

This PR updates the database connection options and PostgreSQL DSN construction so the application can explicitly target a configured database name instead of relying on PostgreSQL defaults.

Changes:

• Added a Database field to database.Options.
• Updated the PostgreSQL DSN format string to include dbname=%s.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

opts.Database is interpolated unconditionally into the Postgres DSN. If Options.Database is left empty, the DSN will contain dbname= with an empty value, which is unlikely to be intended. Consider validating opts.Database (return a clear error) or conditionally omitting dbname/defaulting it (e.g., to opts.Username) to preserve previous behavior for existing callers.

Suggested change

	dsn := fmt.Sprintf("host=%s user=%s password=%s port=%s dbname=%s", opts.Host, opts.Username, opts.Password, opts.Port, opts.Database)
	dsn := fmt.Sprintf("host=%s user=%s password=%s port=%s", opts.Host, opts.Username, opts.Password, opts.Port)
	if opts.Database != "" {
	dsn = fmt.Sprintf("%s dbname=%s", dsn, opts.Database)
	}

[sm-28601]

Thanks for the thorough review! I have applied both suggestions: made the dbname interpolation conditional and properly wired the logger for the Postgres configuration.

[Copilot]

The SQLITE branch applies opts.Logger to gorm.Config, but the POSTGRES branch always uses an empty gorm.Config{}. If callers set Options.Logger, it will currently be ignored for Postgres connections. Consider wiring opts.Logger.DatabaseLogger() into the Postgres gorm.Config the same way as SQLITE for consistent behavior.

Suggested change

	db, err := gorm.Open(postgres.Open(dsn), &gorm.Config{})
	config := &gorm.Config{}
	if opts.Logger != nil {
	config.Logger = opts.Logger.DatabaseLogger()
	}
	db, err := gorm.Open(postgres.Open(dsn), config)

[sm-28601]

Thanks for the thorough review! I have applied both suggestions: made the dbname interpolation conditional and properly wired the logger for the Postgres configuration.

[Omkar-Ugal]

Can you clarify why dbname is needed here? What issue were we facing without it?

[sm-28601]

Can you clarify why dbname is needed here? What issue were we facing without it?

Without the dbname parameter, PostgreSQL automatically tries to connect to a database matching the operating username. We needed this fix because users were unable to connect to a specific, custom database (like mesherydb) using the Options struct. It restricted the app to only using the default user-named database.

[leecalcote]

Please validate and improve error handling when Database is empty for Postgres.

Is meshery set as the default database name somewhere?

[sm-28601]

Please validate and improve error handling when Database is empty for Postgres.

Is meshery set as the default database name somewhere?

No, "meshery" is not set as a default database name anywhere. The Postgres path in meshkit is currently unused by Meshery (which uses SQLite) .