Agents - switch back to using repository state in the session tracker to avoid a race condition#309169
Open
Agents - switch back to using repository state in the session tracker to avoid a race condition#309169
Conversation
… to avoid a race condition
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Copilot Agents session repository tracking logic to listen to Git repository state changes (via IGitService) instead of relying on file system watchers, aiming to avoid a race condition while keeping session change metadata up to date.
Changes:
- Replace workspace file system watchers with Git repository state listeners (
repository.state.onDidChange). - Add
IGitServicedependency to open repositories and subscribe to state changes. - Rename internal tracking/disposal structures from workspace “watchers” to repository watchers.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/extension/chatSessions/vscode-node/chatSessionRepositoryTracker.ts | Switches from filesystem-based change detection to Git repository state change tracking for session refresh/cache invalidation. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 3
extensions/copilot/src/extension/chatSessions/vscode-node/chatSessionRepositoryTracker.ts
Show resolved
Hide resolved
extensions/copilot/src/extension/chatSessions/vscode-node/chatSessionRepositoryTracker.ts
Outdated
Show resolved
Hide resolved
extensions/copilot/src/extension/chatSessions/vscode-node/chatSessionRepositoryTracker.ts
Outdated
Show resolved
Hide resolved
roblourens
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.