Security: OAuth callback does not validate state parameter#1189
Open
tuanaiseo wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
Conversation
The OAuth callback flow accepts an authorization `code` from the URL and proceeds with token exchange, but there is no validation of the OAuth `state` parameter to bind the response to the original auth request. This can enable login CSRF/session mix-up attacks where an attacker injects a valid code for a different authorization context. Affected files: OAuthCallback.tsx, AppRenderer.tsx Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
The OAuth callback flow accepts an authorization `code` from the URL and proceeds with token exchange, but there is no validation of the OAuth `state` parameter to bind the response to the original auth request. This can enable login CSRF/session mix-up attacks where an attacker injects a valid code for a different authorization context. Affected files: OAuthCallback.tsx, AppRenderer.tsx Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The OAuth callback flow accepts an authorization
codefrom the URL and proceeds with token exchange, but there is no validation of the OAuthstateparameter to bind the response to the original auth request. This can enable login CSRF/session mix-up attacks where an attacker injects a valid code for a different authorization context.Severity:
highFile:
client/src/components/OAuthCallback.tsxSolution
Store a cryptographically-random
statevalue before redirecting to the authorization server, include it in the auth request, parsestatefrom callback parameters, and reject the callback if it does not exactly match the stored value. Also clear the stored state after successful validation.Changes
client/src/components/OAuthCallback.tsx(modified)client/src/components/AppRenderer.tsx(modified)Testing