Security: Potential reverse tabnabbing via window.open with _blank#1190
Open
tuanaiseo wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
External links are opened with `window.open(url, "_blank")` without `noopener`/`noreferrer`. A newly opened page can potentially access `window.opener` and navigate the original inspector window, enabling phishing-style attacks. Affected files: AppRenderer.tsx Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
External links are opened with
window.open(url, "_blank")withoutnoopener/noreferrer. A newly opened page can potentially accesswindow.openerand navigate the original inspector window, enabling phishing-style attacks.Severity:
mediumFile:
client/src/components/AppRenderer.tsxSolution
Open untrusted URLs using
window.open(url, "_blank", "noopener,noreferrer")and/or explicitly setnewWindow.opener = nullafter opening.Changes
client/src/components/AppRenderer.tsx(modified)Testing