support qwen3.6 grpo & in-place add lora#163
Open
hjh0119 wants to merge 5 commits intomodelscope:mainfrom
Open
support qwen3.6 grpo & in-place add lora#163hjh0119 wants to merge 5 commits intomodelscope:mainfrom
hjh0119 wants to merge 5 commits intomodelscope:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a GRPO training script for the GSM8K dataset and implements support for Mixture-of-Experts (MoE) models within the Ray-based training framework. Key changes include specialized LoRA weight synchronization for MoE layers in the vLLM sampler, which now buckets expert weights separately and accumulates them on the CPU to prevent memory issues. Feedback was provided regarding a potential runtime error in the Megatron model logic where a variable could be accessed before being defined.
tastelikefeet
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.