fix(lib): prevent memory leak by removing TypeVar subscript in construct_type_unchecked (#3084)#3091
Open
cloudyun888 wants to merge 1 commit intoopenai:mainfrom
Open
Conversation
…uct_type_unchecked Pydantic model_rebuild fails for TypeVar-subscripted generics like ParsedResponse[TextFormatT] because TextFormatT is unresolved at runtime. This causes model_rebuild(raise_errors=False) to return False on every call, preventing _built_memo caching and allocating a new SchemaValidator/SchemaSerializer on every parse_response() call. Fix: use non-parameterized base classes (ParsedResponseOutputText, ParsedResponseOutputMessage, ParsedResponse) which Pydantic can resolve at runtime. Fixes openai#3084
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using client with structured outputs, is called with TypeVar-subscripted generics like . Since is an unresolved module-level TypeVar at runtime, Pydantic cannot resolve it, causing to always return . This prevents caching, allocating a new / (heavy Rust objects) on every call — a unbounded memory leak.
Changes
Non-parameterized base classes resolve correctly at runtime and Pydantic can cache their schemas.
Testing
Run a workload with structured outputs under memory profiling. Before fix: unbounded growth of SchemaValidator objects. After fix: stable memory usage.
Fixes #3084