[release-4.20] OCPBUGS-77037: Fix QueryBrowser import to use SDK path to avoid circular dependency by Leo6Leo · Pull Request #16222 · openshift/console

Leo6Leo · 2026-03-30T18:24:24Z

Summary

Custom fix for release-4.20 replacing the failed cherry-pick in [release-4.20] OCPBUGS-77037: Fixed Metrics page React error #306 by exporting QueryBrowser component #16040
Imports QueryBrowser from @console/dynamic-plugin-sdk/src/lib-core instead of @console/shared/src/components/query-browser to break the circular import that causes React error Add Alert Manager proxy #306 on the Metrics page
Updates the test file to import from the same SDK path so Enzyme's find(QueryBrowser) matches by reference, fixing the 3 test failures in MonitoringDashboardGraph.spec.tsx

Context

The automated cherry-pick PR #16040 (from #16016) changed the component import but not the test import, causing a reference mismatch where Enzyme could not find the QueryBrowser component in the shallow-rendered tree.

Test plan

CI ci/prow/frontend tests pass (the 3 previously failing MonitoringDashboardGraph tests)
Navigate to Observe → Metrics page — no React error Add Alert Manager proxy #306

🤖 Generated with Claude Code

…lar dependency Import QueryBrowser from @console/dynamic-plugin-sdk/src/lib-core instead of @console/shared/src/components/query-browser to break circular imports that cause React error openshift#306 on the Metrics page. Also update the test to import from the same path so Enzyme's find() matches by reference. Co-Authored-By: Claude <noreply@anthropic.com>

openshift-ci-robot · 2026-03-30T18:24:34Z

@Leo6Leo: This pull request references Jira Issue OCPBUGS-77037, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected dependent Jira Issue OCPBUGS-74557 to target a version in 4.21.0, 4.21.z, but it targets "4.22.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Custom fix for release-4.20 replacing the failed cherry-pick in [release-4.20] OCPBUGS-77037: Fixed Metrics page React error #306 by exporting QueryBrowser component #16040

Imports QueryBrowser from @console/dynamic-plugin-sdk/src/lib-core instead of @console/shared/src/components/query-browser to break the circular import that causes React error Add Alert Manager proxy #306 on the Metrics page

Updates the test file to import from the same SDK path so Enzyme's find(QueryBrowser) matches by reference, fixing the 3 test failures in MonitoringDashboardGraph.spec.tsx

Context

The automated cherry-pick PR #16040 (from #16016) changed the component import but not the test import, causing a reference mismatch where Enzyme could not find the QueryBrowser component in the shallow-rendered tree.

Test plan

CI ci/prow/frontend tests pass (the 3 previously failing MonitoringDashboardGraph tests)

Navigate to Observe → Metrics page — no React error Add Alert Manager proxy #306

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-03-30T18:25:18Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 11b705cf-d6fa-455a-bd4f-971cf771b56d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Leo6Leo · 2026-03-30T18:32:19Z

/jira refresh

openshift-ci-robot · 2026-03-30T18:32:25Z

@Leo6Leo: This pull request references Jira Issue OCPBUGS-77037, which is invalid:

expected dependent Jira Issue OCPBUGS-74557 to target a version in 4.21.0, 4.21.z, but it targets "4.21" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Leo6Leo · 2026-03-30T18:33:10Z

/jira refresh

openshift-ci-robot · 2026-03-30T18:33:16Z

@Leo6Leo: This pull request references Jira Issue OCPBUGS-77037, which is invalid:

expected dependent Jira Issue OCPBUGS-74557 to target a version in 4.21.0, 4.21.z, but it targets "4.22.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Leo6Leo · 2026-03-30T18:34:14Z

/jira refresh

openshift-ci-robot · 2026-03-30T18:34:24Z

@Leo6Leo: This pull request references Jira Issue OCPBUGS-77037, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.20.z) matches configured target version for branch (4.20.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-74557 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-74557 targets the "4.21.z" version, which is one of the valid target versions: 4.21.0, 4.21.z
bug has dependents

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Leo6Leo · 2026-03-30T21:01:36Z

/retest-required

Leo6Leo · 2026-03-31T13:56:35Z

/retest-required

yapei · 2026-04-08T06:10:03Z

Do 419 to 420 upgrade and make sure no react error when visiting Observe → Metrics page
ci/prow/frontend tests pass

/verified by @yapei

openshift-ci-robot · 2026-04-08T06:10:17Z

@yapei: This PR has been marked as verified by @yapei.

Details

In response to this:

Do 419 to 420 upgrade and make sure no react error when visiting Observe → Metrics page

ci/prow/frontend tests pass

/verified by @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

logonoff

/lgtm

openshift-ci · 2026-04-11T20:20:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leo6Leo, logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/packages/dev-console/OWNERS~~ [logonoff]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

logonoff · 2026-04-11T20:20:47Z

/label backport-risk-assessed

openshift-merge-bot · 2026-04-12T00:29:14Z

/retest-required

Remaining retests: 0 against base HEAD 4586aa2 and 2 for PR HEAD 3b4ed51 in total

openshift-ci · 2026-04-12T09:23:38Z

@Leo6Leo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-console	`3b4ed51`	link	unknown	`/test e2e-gcp-console`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci bot requested review from rhamilto and sg00dwin March 30, 2026 18:25

openshift-ci bot added the component/dev-console Related to dev-console label Mar 30, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 30, 2026

openshift-ci bot requested a review from yapei March 30, 2026 18:34

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 8, 2026

logonoff approved these changes Apr 11, 2026

View reviewed changes

openshift-ci bot assigned logonoff Apr 11, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2026

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2026

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 11, 2026

openshift-ci bot assigned sanketpathak and yapei Apr 11, 2026

Conversation

Leo6Leo commented Mar 30, 2026

Summary

Context

Test plan

Uh oh!

openshift-ci-robot commented Mar 30, 2026

Summary

Context

Test plan

Uh oh!

coderabbitai bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Leo6Leo commented Mar 30, 2026

Uh oh!

openshift-ci-robot commented Mar 30, 2026

Uh oh!

Leo6Leo commented Mar 30, 2026

Uh oh!

openshift-ci-robot commented Mar 30, 2026

Uh oh!

Leo6Leo commented Mar 30, 2026

Uh oh!

openshift-ci-robot commented Mar 30, 2026

Uh oh!

Leo6Leo commented Mar 30, 2026

Uh oh!

Leo6Leo commented Mar 31, 2026

Uh oh!

yapei commented Apr 8, 2026

Uh oh!

openshift-ci-robot commented Apr 8, 2026

Uh oh!

logonoff left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Apr 11, 2026

Uh oh!

logonoff commented Apr 11, 2026

Uh oh!

openshift-merge-bot bot commented Apr 12, 2026

Uh oh!

openshift-ci bot commented Apr 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coderabbitai bot commented Mar 30, 2026 •

edited

Loading