feat: add positive and negative thresholds for score change evaluation#98
Open
bjohansebas wants to merge 7 commits intoossf:mainfrom
Open
feat: add positive and negative thresholds for score change evaluation#98bjohansebas wants to merge 7 commits intoossf:mainfrom
bjohansebas wants to merge 7 commits intoossf:mainfrom
Conversation
bjohansebas
force-pushed
the
diff
branch
3 times, most recently
from
f5836dd to
f62e381
Compare
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
…te action inputs Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Author
|
Okay, this still doesn’t prevent a pull request from being created when there are no changes in the diff. |
… content Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
…ate database change check Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Author
|
Now it does take the score changes into account. |
bjohansebas
commented
Jan 10, 2026
| : reportContent) | ||
| const scoreChanges = scores.filter(score => score.currentDiff !== undefined) | ||
|
|
||
| if (scoreChanges.length) { |
Author
There was a problem hiding this comment.
With this, we could already make it output whether something changed. Issue #34 would be completed, but I’d prefer to do that in another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #88