chore(ci): run acceptance tests in GitHub workflows#1237
Draft
phil-davis wants to merge 33 commits intomasterfrom
Draft
chore(ci): run acceptance tests in GitHub workflows#1237phil-davis wants to merge 33 commits intomasterfrom
phil-davis wants to merge 33 commits intomasterfrom
Conversation
phil-davis
force-pushed
the
acceptance-tests-http-1
branch
2 times, most recently
from
5c29c2a to
e4ba790
Compare
This allows settings like: AllowOverride All to happen. The final way to do this needs to be thought about, bwecause we want to put the potential site conf files somewhere that will be a common place for all app CI to get them. And there should be flexibility about the names "server" and "federated".
When deleting files, the activity message about the delete is not always at gthe top of the list. So the existing check sometimes fails, but passes when the test scenario is run again. So check for the expected activity message anywhere in the list, it is not essential that it be right at the top.
phil-davis
force-pushed
the
acceptance-tests-http-1
branch
from
e4ba790 to
1d1bf4a
Compare
phil-davis
force-pushed
the
acceptance-tests-http-1
branch
from
093b1f6 to
f6501f6
Compare
This is code from core for processing a trashbin restore. It did not account for when the server is installed in a subfolder, and the href of items has the subfolder at the front. "/server/remote.php/dav/trash-bin/Alice/" The code here is copied from core TrashbinContext and adjusted to expect the subfolder at the front of the href. If it works, then it will need to go in the core code.
phil-davis
force-pushed
the
acceptance-tests-http-1
branch
from
f6501f6 to
f3b134e
Compare
to get the fix for the trashbin restore acceptance test.
phil-davis
force-pushed
the
acceptance-tests-http-1
branch
from
4f959f1 to
59b77fa
Compare
the same as was done in owncloud-ci/php
to explicitly tell where the server and federated installs should be served.
phil-davis
force-pushed
the
acceptance-tests-http-1
branch
3 times, most recently
from
b4839e1 to
c6ef169
Compare
phil-davis
force-pushed
the
acceptance-tests-http-1
branch
from
c6ef169 to
1e8e4a0
Compare
Contributor
Author
|
I finally go it to pass! Next is to look through this and tidy it up. |
and minor cleanup
phil-davis
force-pushed
the
acceptance-tests-http-1
branch
6 times, most recently
from
4528b0c to
1fb7474
Compare
phil-davis
force-pushed
the
acceptance-tests-http-1
branch
from
1fb7474 to
eb8a887
Compare
The Apache site conf files are now stored in core tests/acceptance/setupApache And sort out the display of settings and log on failure()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is where I got up to earlier today, before I started trying to get it all to work with https
The drone pipelines did work without https being set up, so probably best to continue working here to debug why some acceptance tests are failing.