Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
5 minute showcase, nothing fancy, just Gemini being Gemini. If you wonder - all models eventually responded, gemini 2.5 was just indexing the codebase for 5 minutes. https://drive.google.com/file/d/1rCZZDvFE1WHKBIQxtC2nuX7uI5bOEAtI/view?usp=sharing |
ApprovabilityVerdict: Needs human review This PR introduces a complete new Gemini CLI provider integration across server and web components, including session management, text generation, UI controls, and settings. As a significant new feature with substantial new runtime behavior, plus an unresolved high-severity bug comment about potentially empty prompts being sent to the CLI, this requires human review. You can customize Macroscope's approvability policy. Learn more. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0baacdd. Configure here.
- VSCode launch.json and tasks.json - Windows-only release workflow (release-fork.yml) - Android Capacitor build setup - Standalone Linux server build with systemd service install - VCS mode setting (git/disabled) Deferred: OpenCode and Gemini-cli implementation (PR pingdotgg#1758, pingdotgg#1983)

Gemini CLI PR. I can provide account for testing if you need so. I have a student one year sub
Summary
Why
Users wanted Gemini CLI support in T3 Code, but the repo only supported Codex and Claude. The integration also needed model-family-aware thinking controls and a few follow-up fixes discovered during live testing.
Impact
Validation
bun fmtbun lintbun typecheckbun run --filter @t3tools/web test src/components/ChatView.logic.test.ts src/components/chat/composerProviderRegistry.test.tsx src/components/chat/TraitsPicker.browser.tsx src/composerDraftStore.test.ts src/providerModels.test.tsbun run --filter t3 test src/provider/Layers/GeminiAdapter.test.ts src/provider/Layers/GeminiProvider.test.ts src/provider/Layers/ProviderAdapterRegistry.test.ts src/provider/Layers/ProviderService.test.tsNote
Add Gemini CLI as a full provider with chat, text generation, and settings support
gemini --versionand an ACP capability discovery session (geminiAcpProbe.ts), refreshing every 2 minutes.extractBalancedJsonSubstringin Utils.ts contains stray+tokens that may cause a compilation error.Macroscope summarized 708e1f5.
Note
High Risk
Large, cross-cutting change that introduces a new Gemini CLI/ACP runtime adapter and provider discovery, plus routes text-generation and UI model/trait selection; failures could impact provider session lifecycle, persistence, or git text-generation flows.
Overview
Adds Gemini as a full provider option end-to-end: server-side ACP session adapter (
GeminiAdapter) with event emission, approvals, turn lifecycle, snapshot/rollback via session file cloning, and integration into the provider registry/service wiring and persisted session directory.Introduces Gemini provider health/model discovery (
GeminiProvider,geminiAcpProbe) that checksgemini --version, probes ACP for authentication and available models, infers model capabilities by family (Gemini 3 thinking levels vs Gemini 2.5 thinking budgets), and includes Gemini in provider caching/order.Extends git text generation to route
provider: "gemini"through a newGeminiTextGenerationLivelayer that shells out to the Gemini CLI with JSON envelope decoding, a 180s timeout, and stronger structured-output extraction viaextractJsonValueFromText(handles code fences and embedded/balanced JSON).Updates the web app to surface Gemini in provider/model pickers and settings, persist Gemini model options (thinking controls) in composer drafts, and gate/render traits controls consistently; adds targeted tests for Gemini adapter behavior, provider probing, registry wiring, rollback persistence, and UI traits/model-option handling.
Reviewed by Cursor Bugbot for commit 708e1f5. Bugbot is set up for automated code reviews on this repo. Configure here.