gh-148474: Fix _Py_hexlify_simd compilation with older clang#148475
Open
jmroot wants to merge 4 commits intopython:mainfrom
Open
gh-148474: Fix _Py_hexlify_simd compilation with older clang#148475jmroot wants to merge 4 commits intopython:mainfrom
jmroot wants to merge 4 commits intopython:mainfrom
Conversation
Apple clang prior to around Xcode 9 does not automatically generate a vector from a scalar shift operator RHS in this case. Doing it explicitly works with all versions and arguably also makes it clearer what is actually happening.
picnixz
reviewed
Apr 13, 2026
picnixz
reviewed
Apr 13, 2026
Misc/NEWS.d/next/Build/2026-04-12-22-54-16.gh-issue-148474.ouIO8R.rst
Outdated
Show resolved
Hide resolved
Member
|
I hope that my NEWS entry change is correct (I don't know if we had the c file directives correctly set up) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apple clang prior to around Xcode 9 does not automatically generate a vector from a scalar shift operator RHS in this case. Doing it explicitly works with all versions and arguably also makes it clearer what is actually happening.