bpo-41544: Add missing parameters to dummy.DummyProcess and dummy.Pool#21869
bpo-41544: Add missing parameters to dummy.DummyProcess and dummy.Pool#21869moi90 wants to merge 7 commits intopython:mainfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
This needs a unit test. |
|
It seems to me that there are not tests at all for I'd appreciate any help with this. |
|
I added test_multiprocessing_dummy and it runs successfully. It shouldn't, however, because EDIT: It seems that if In my eyes, to make use of the current test machinery, we need to make "dummy" a supported (but maybe undocumented) start method. EDIT: I see why this doesn't work: The |
|
I moved on to checking only the signatures. Also, I added the missing |
|
@ZackerySpytz What do you think? |
|
This PR is stale because it has been open for 30 days with no activity. |
Introduce daemon parameter to multiprocessing.dummy.DummyProcess in order to match the API of multiprocessing.
|
I rebased the changes onto main. @ezio-melotti Why was the |
The CLA is now handled by the "CLA Signing" check (which passes successfully). |
Add missing parameters to multiprocessing.dummy.DummyProcess in order to match the API of multiprocessing.Process.
https://bugs.python.org/issue41544