Skip to content

Add clarification that contributors must authorize the Python CLA bot#1667

Merged
willingc merged 3 commits intopython:mainfrom
SarahPythonista:add-details-signing-CLA
Apr 17, 2026
Merged

Add clarification that contributors must authorize the Python CLA bot#1667
willingc merged 3 commits intopython:mainfrom
SarahPythonista:add-details-signing-CLA

Conversation

@SarahPythonista
Copy link
Copy Markdown
Contributor

@SarahPythonista SarahPythonista commented Oct 11, 2025

@SarahPythonista
Copy link
Copy Markdown
Contributor Author

This is to give the user a heads up on which permissions they'll need to provide; it previously just said to log in to GitHub but didn't mention giving permissions to the bot. Please let me know if I need to open an issue.

authors are required to sign a Contributor License Agreement, click
on the button in the comment to sign it. It's enough to log in through
GitHub. The process is automatic.
on the button in the comment to sign it. Simply log in to GitHub,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
on the button in the comment to sign it. Simply log in to GitHub,
on the button in the comment to sign it. Log in to GitHub,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit odd now, originally it was through but now it is to? It is an SSO, you do not directly log into GitHub. I propose (combined with Mariatta's suggestion, since IIRC two from the same thread cannot be applied):

Suggested change
on the button in the comment to sign it. Simply log in to GitHub,
on the button in the comment to sign it. Log in with GitHub,

Copy link
Copy Markdown
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SarahPythonista for your contribution.

Comment thread getting-started/pull-request-lifecycle.rst Outdated
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
@read-the-docs-community
Copy link
Copy Markdown

read-the-docs-community bot commented Apr 17, 2026

Documentation build overview

📚 CPython devguide | 🛠️ Build #32300423 | 📁 Comparing fcaf3f3 against latest (a5e6aad)

  🔍 Preview build  

2 files changed
± versions/index.html
± getting-started/pull-request-lifecycle/index.html

@SarahPythonista
Copy link
Copy Markdown
Contributor Author

Thanks @Mariatta and @willingc!

@willingc willingc merged commit 76bb6bb into python:main Apr 17, 2026
5 checks passed
@willingc
Copy link
Copy Markdown
Collaborator

Thanks @SarahPythonista. 💐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants